public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: OMAP: Fix warning in dsp_ctl_core.c
@ 2007-05-18  7:13 Dirk Behme
  2007-05-18 15:47 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Dirk Behme @ 2007-05-18  7:13 UTC (permalink / raw)
  To: linux-omap-open-source

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]


Fix warning

arch/arm/plat-omap/dsp/dsp_ctl_core.c: In function 'dsp_ctl_core_open':
arch/arm/plat-omap/dsp/dsp_ctl_core.c:46: warning: ignoring return
value of 'mutex_lock_interruptible', declared with attribute
warn_unused_result

Signed-off-by: Dirk Behme <dirk.behme@gmail.com>

[-- Attachment #2: dsp_ctl_core_warning_fix.txt --]
[-- Type: text/plain, Size: 526 bytes --]

Index: linux-osk/arch/arm/plat-omap/dsp/dsp_ctl_core.c
===================================================================
--- linux-osk.orig/arch/arm/plat-omap/dsp/dsp_ctl_core.c
+++ linux-osk/arch/arm/plat-omap/dsp/dsp_ctl_core.c
@@ -43,7 +43,8 @@ static int dsp_ctl_core_open(struct inod
 	static DEFINE_MUTEX(open_lock);
 	int ret = 0;
 
-	mutex_lock_interruptible(&open_lock);
+	if (mutex_lock_interruptible(&open_lock))
+		return -EINTR;
 	if (omap_dsp->initialized == 0) {
 		ret = dsp_late_init();
 		if (ret != 0) {


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: OMAP: Fix warning in dsp_ctl_core.c
  2007-05-18  7:13 [PATCH] ARM: OMAP: Fix warning in dsp_ctl_core.c Dirk Behme
@ 2007-05-18 15:47 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2007-05-18 15:47 UTC (permalink / raw)
  To: Dirk Behme; +Cc: linux-omap-open-source

* Dirk Behme <dirk.behme@googlemail.com> [070518 00:16]:
>
> Fix warning
>
> arch/arm/plat-omap/dsp/dsp_ctl_core.c: In function 'dsp_ctl_core_open':
> arch/arm/plat-omap/dsp/dsp_ctl_core.c:46: warning: ignoring return
> value of 'mutex_lock_interruptible', declared with attribute
> warn_unused_result
>
> Signed-off-by: Dirk Behme <dirk.behme@gmail.com>

> Index: linux-osk/arch/arm/plat-omap/dsp/dsp_ctl_core.c
> ===================================================================
> --- linux-osk.orig/arch/arm/plat-omap/dsp/dsp_ctl_core.c
> +++ linux-osk/arch/arm/plat-omap/dsp/dsp_ctl_core.c
> @@ -43,7 +43,8 @@ static int dsp_ctl_core_open(struct inod
>  	static DEFINE_MUTEX(open_lock);
>  	int ret = 0;
>  
> -	mutex_lock_interruptible(&open_lock);
> +	if (mutex_lock_interruptible(&open_lock))
> +		return -EINTR;
>  	if (omap_dsp->initialized == 0) {
>  		ret = dsp_late_init();
>  		if (ret != 0) {
> 

Pushing today.

Tony

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-05-18 15:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-18  7:13 [PATCH] ARM: OMAP: Fix warning in dsp_ctl_core.c Dirk Behme
2007-05-18 15:47 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox