public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: andrzej zaborowski <balrogg@gmail.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] Re-add a lost TSC2102 touchscreen Kconfig entry
Date: Tue, 22 May 2007 16:40:50 -0700	[thread overview]
Message-ID: <200705221640.51098.david-b@pacbell.net> (raw)
In-Reply-To: <fb249edb0705221022s5bec31d4r77bfc16373262b4e@mail.gmail.com>

On Tuesday 22 May 2007, andrzej zaborowski wrote:
> The TSC2102 option in drivers/input/touchscreen/Kconfig got lost
> somewhere in January (although the commit is not visible in git-web),
> so adding it back. 

I noticed that ... by the way, it looked to me like it should be
very possible to make this TSC2102 touchscreen code work on the
TSC2101 too.  I think someone should

  - Make such a common touchscreen core (maybe there's stuff to
    be borrowed from the tsc2301 touchscreen too, but not all
    the relevant page 1 registers are the same on tsc2301).

  - Move more of the IRQ handling logic from tsc2102.c into the
    shared touchscreen code ... have it manage irqs etc, it can
    get the number from a platform_device resource as usual.

  - Have proper hwmon support for the other ADC devices on the
    two chips (battery, aux, and temp sensors ... the chips have
    different numbers of each).

    Looks tricky to safely split touchscreen ADC client code
    from the hwmon sensors, so I'd suggest keeping it together
    in one module.  (That's what ads7846 does, FWIW.)

Looks to me like other than the audio support (which should also
probably convert to use the new sound/soc/* framework), large parts
of the tsc2101 and tsc2102 drivers should be identical.  There
are a few bits that would need to have "switch(chiptype){...}",
but core code can -- should! -- be the same.

- Dave

  reply	other threads:[~2007-05-22 23:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-22 17:22 [PATCH] Re-add a lost TSC2102 touchscreen Kconfig entry andrzej zaborowski
2007-05-22 23:40 ` David Brownell [this message]
2007-05-23 15:41   ` Tony Lindgren
2007-05-23 23:54   ` andrzej zaborowski
2007-05-25  0:31 ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200705221640.51098.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=balrogg@gmail.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox