RE: [PATCH] MUSB HSET driver

Pandita, Vikram
2007-05-23T09:44:45Z

>On Wednesday 23 May 2007, Pandita, Vikram wrote:
>> Hi Tony
>> As per Greg's suggestion of introducing HSET driver in ope
>> n source, can we push the HSET driver into MUSB for now till
>> a complete implementation is made available in open source?
>
>Please, no.
>
>This doesn't need to be musb-specific, and if it gets merged
>it'll just create more pain to rip it out when musb_hdrc goes
>upstream.

Agreed

>
>A much cleaner approach is to just do this in userspace with
>usbfs ... issuing control requests to the hub ports. That
>will work with *ANY* high speed controller.

I think Felipe Balbi will be looking into that aspect.

But how will that work for HSET tests with OPT card with OMAP as host.
We still need to write a class driver that issues the TEST command to hub based on VID/PID sent by OPT. And that is what I am proposing.
Comments please.

>
>If the existing test mode support in the musb root hub is not
>enough, just fix that bug.

The musb hset current implementation that I have does not use the USB_PORT_FEAT_TEST path of the HUB but a custom test path.
Based on your inputs for generic class driver for OPT, I will make the changes.

>
>- Dave