Re: [PATCH] MUSB HSET driver

David Brownell
2007-05-23T09:34:37Z

On Wednesday 23 May 2007, Pandita, Vikram wrote:
> Hi Tony
> As per Greg's suggestion of introducing HSET driver in ope
> n source, can we push the HSET driver into MUSB for now till
> a complete implementation is made available in open source?

Please, no.

This doesn't need to be musb-specific, and if it gets merged
it'll just create more pain to rip it out when musb_hdrc goes
upstream.

A much cleaner approach is to just do this in userspace with
usbfs ... issuing control requests to the hub ports. That
will work with *ANY* high speed controller.

If the existing test mode support in the musb root hub is not
enough, just fix that bug.

- Dave