From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@mvista.com>
Cc: Linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] OMAP: 2430SDP: Support LCD display as a FB device
Date: Fri, 25 May 2007 15:49:45 -0700 [thread overview]
Message-ID: <20070525224945.GJ21314@atomide.com> (raw)
In-Reply-To: <465766A0.8020105@mvista.com>
* Kevin Hilman <khilman@mvista.com> [070525 15:44]:
> nishanth menon wrote:
> > Tony,
> >
> > On 5/25/07, Tony Lindgren <tony@atomide.com> wrote:
> >> * Hunyue Yau <hyau@mvista.com> [070525 15:19]:
> >> > Add glue to control the 2430SDP LCD as a frame buffer device
> >> > using the existing dispc.c driver under omapfb.
> >>
> >> Thanks, pushing today.
> > Why are we having so many board-2430sdp variants? we now have
> > arch/arm/mach-omap2/board-2430sdp.c
> > arch/arm/mach-omap2/board-2430sdp-flash.c
> > arch/arm/mach-omap2/board-2430sdp-usb.c. Now one more... cant we plug
> > these 100 liner codes into board-2430sdp.c?
>
> Hmm, the display changes were indeed added to board-2430.c, not to anthoer new file.
>
> Personally, I think the multiple board files are easier to read, and cleaner. Did you notice all the board-n800* files?
Yeah eventually we may want to have subdirectories for each board if
there are lots of devices to initialize. But let's not do that right
now :)
Tony
next prev parent reply other threads:[~2007-05-25 22:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 22:18 [PATCH] OMAP: 2430SDP: Support LCD display as a FB device Hunyue Yau
2007-05-25 22:33 ` Tony Lindgren
2007-05-25 22:36 ` nishanth menon
2007-05-25 22:43 ` Kevin Hilman
2007-05-25 22:49 ` Tony Lindgren [this message]
2007-05-25 23:04 ` Dmitry Krivoschekov
2007-05-26 0:20 ` Hunyue Yau
2007-05-25 23:20 ` Syed Mohammed, Khasim
2007-05-25 23:42 ` Kevin Hilman
2007-05-25 23:51 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070525224945.GJ21314@atomide.com \
--to=tony@atomide.com \
--cc=Linux-omap-open-source@linux.omap.com \
--cc=khilman@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox