From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] OMAP: 2430SDP: Support LCD display as a FB device Date: Fri, 25 May 2007 15:49:45 -0700 Message-ID: <20070525224945.GJ21314@atomide.com> References: <200705251518.13137.hyau@mvista.com> <20070525223324.GF21314@atomide.com> <782515bb0705251536g5d3bb24dw419df48535fc9082@mail.gmail.com> <465766A0.8020105@mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <465766A0.8020105@mvista.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: Kevin Hilman Cc: Linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org * Kevin Hilman [070525 15:44]: > nishanth menon wrote: > > Tony, > > > > On 5/25/07, Tony Lindgren wrote: > >> * Hunyue Yau [070525 15:19]: > >> > Add glue to control the 2430SDP LCD as a frame buffer device > >> > using the existing dispc.c driver under omapfb. > >> > >> Thanks, pushing today. > > Why are we having so many board-2430sdp variants? we now have > > arch/arm/mach-omap2/board-2430sdp.c > > arch/arm/mach-omap2/board-2430sdp-flash.c > > arch/arm/mach-omap2/board-2430sdp-usb.c. Now one more... cant we plug > > these 100 liner codes into board-2430sdp.c? > > Hmm, the display changes were indeed added to board-2430.c, not to anthoer new file. > > Personally, I think the multiple board files are easier to read, and cleaner. Did you notice all the board-n800* files? Yeah eventually we may want to have subdirectories for each board if there are lots of devices to initialize. But let's not do that right now :) Tony