public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: nishanth menon <menon.nishanth@gmail.com>
Cc: Linux OMAP <linux-omap-open-source@linux.omap.com>
Subject: Re: [PATCH 1/2] OMAP: Kill compile warnings
Date: Fri, 25 May 2007 16:12:16 -0700	[thread overview]
Message-ID: <20070525231215.GL21314@atomide.com> (raw)
In-Reply-To: <782515bb0705251604l20d57f49h45584f2ab7f28f36@mail.gmail.com>

* nishanth menon <menon.nishanth@gmail.com> [070525 16:05]:
> Got the subject wrong last time.. Sorry..
> kill warning1: remove link to .init.text
> omap_timer refers to __init omap2_gp_timer_init function causing a warning
> while the linking is done
>
> Signed-off-by: Nishanth Menon <menon.nishanth@gmail.com>
> ---
> arch/arm/mach-omap2/timer-gp.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/timer-gp.c 
> b/arch/arm/mach-omap2/timer-gp.c
> index 8f380a1..f4cf6fe 100644
> --- a/arch/arm/mach-omap2/timer-gp.c
> +++ b/arch/arm/mach-omap2/timer-gp.c
> @@ -175,6 +175,6 @@ static void __init omap2_gp_timer_init(void)
> 	omap2_gp_clocksource_init();
> }
>
> -struct sys_timer omap_timer = {
> -	.init	= omap2_gp_timer_init,
> +struct sys_timer omap_timer __initdata = {
> +	.init	 = omap2_gp_timer_init,
> };
> -- 

This warning is wrong, and we cannot mark sys_timer as initdata. See
other mails related to this on this list. I'd assume this will get fixed
once sys_timer is added to the list of things to ignore.

Tony

  reply	other threads:[~2007-05-25 23:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-25 23:04 [PATCH 1/2] OMAP: Kill compile warnings nishanth menon
2007-05-25 23:12 ` Tony Lindgren [this message]
2007-05-25 23:17   ` Syed Mohammed, Khasim
2007-05-25 23:23     ` nishanth menon
2007-05-25 23:25       ` Syed Mohammed, Khasim
2007-05-26  5:38         ` Dirk Behme
2007-06-05 10:11           ` Tony Lindgren
2007-06-05 10:21             ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070525231215.GL21314@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=menon.nishanth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox