public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH 1/3] ARM: OMAP: Use new style I2C driver for Menelaus chip.
Date: Sat, 26 May 2007 19:41:35 -0700	[thread overview]
Message-ID: <200705261941.38206.david-b@pacbell.net> (raw)
In-Reply-To: <5d5443650705260127i7df36971p102519abdce22849@mail.gmail.com>

Looks good to me, except for the omap_cfg_reg() call you left in
the driver.  See my next email.

- Dave

      reply	other threads:[~2007-05-27  2:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-26  8:27 [PATCH 1/3] ARM: OMAP: Use new style I2C driver for Menelaus chip Trilok Soni
2007-05-27  2:41 ` David Brownell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200705261941.38206.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox