public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Trilok Soni <soni.trilok@gmail.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH 2/3] ARM: OMAP: menelaus chip info for H4 board.
Date: Tue, 29 May 2007 06:09:48 -0700	[thread overview]
Message-ID: <200705290609.48235.david-b@pacbell.net> (raw)
In-Reply-To: <5d5443650705290533x7883a94bv50ce4e10a209d4b3@mail.gmail.com>

On Tuesday 29 May 2007, Trilok Soni wrote:
> > --- h4.orig/arch/arm/mach-omap2/board-h4.c      2007-05-26 19:35:17.000000000 -0700
> > +++ h4/arch/arm/mach-omap2/board-h4.c   2007-05-26 19:35:24.000000000 -0700
> > @@ -493,12 +493,15 @@ static void __init tusb_evm_setup(void)
> >  #endif
> >
> >  static struct i2c_board_info __initdata h4_i2c_board_info[] = {
> > -#ifdef CONFIG_MENELAUS
> > +       {
> > +               I2C_BOARD_INFO("rtc-rs5c372", 0x32),
> > +               .type = "rv5c387a",
> 
> Where you have used driver_name "rtc-rs5c372" in the menelaus.c
> driver?

There's an rv5c387a chip on the board too.  See

  http://groups.google.com/group/rtc-linux/msg/fa462b52470149d8


> while registering rtc device you have used same "menelaus" as 
> DRIVER_NAME.

Sure, but that's for a different chip.  Both need i2c_board_info.


> Actually I am trying to use new I2C style to TWL4030 core driver, as
> it has four slaves which I want to register with i2c_board_info
> structure along with main driver name "twl4030" and slaves being
> "twl4030:0", "twl4030:1" and so on. But ->probe will be called for
> only main driver "twl4030" not for each slaves as per the i2c core
> correct?

I have no idea what you're talking about here.  Menelaus is
twl92330, yes?  H4 doesn't have a twl4030...

- Dave

  reply	other threads:[~2007-05-29 13:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-26  8:28 [PATCH 2/3] ARM: OMAP: menelaus chip info for H4 board Trilok Soni
2007-05-27  2:44 ` David Brownell
2007-05-29 12:33   ` Trilok Soni
2007-05-29 13:09     ` David Brownell [this message]
2007-05-29 13:29       ` Trilok Soni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200705290609.48235.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=soni.trilok@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox