Re: [PATCH 5/11] Adding OMAP3430 support to mach-omap2

[Tony Lindgren <tony@atomide.com>]

* Syed Mohammed, Khasim <x0khasim@ti.com> [070529 10:33]:
> Hi Tony,
> 
> >>  clock_34xx.c | 1255
> >+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >
> ><snip>
> >
> >Well clock_34xx.c can be merged to existing clock.c. With Pau's PRCM
> >patches, only few registers are different now.
> >
> 
> Can we keep this for now? We can start a different thread for Clock and PRCM for 3430. It will take a while before it gets stabilized. Mean while can we get 3430 booting in tree.

Let's just leave out the clock code for now and keep it as a separate
patch.

> >>  void __init omap2_check_revision(void)
> >> @@ -119,7 +119,11 @@ void __init omap2_check_revision(void)
> >>  	system_rev |= rev << 8;
> >>
> >>  	/* Add the cpu class info (24xx) */
> >> +#ifndef CONFIG_ARCH_OMAP3
> >>  	system_rev |= 0x24;
> >> +#else
> >> +	system_rev |= 0x34;
> >> +#endif
> >>
> >>  	pr_info("OMAP%04x", system_rev >> 16);
> >>  	if ((system_rev >> 8) & 0x0f)
> >
> >This is yet another artificial barrier to compile in many revisions,
> >let's try to avoid that. You should be able to set system_rev based
> >on the hardware register values.
> 
> The current 3430 version doesn't populate these kind of registers, we have to wait for a while for second version. Till then we have to use this kind of mechanism. The 2430 ones support these registers, but it will be a different patch to deal with. For, 3430 I will prefer keeping same thing for a while.

:)

OK, can you add a REVISIT comment there then?

Tony