Re: [RFC] io.c for OMAP3430

[Tony Lindgren <tony@atomide.com>]

* Syed Mohammed, Khasim <x0khasim@ti.com> [070529 21:13]:
> Hi Tony,
> 
> I have incorporated your review comments for io.c. 
> 
> Please do let me know if you find any further issues.
> 
> I have incorporated other review comments from Andrew and Trilok, will regenerate and publish
> the patch set once we agree upon these (irq.c and io.c) patch set.

Well I was thinking we'd have different structs:

#ifdef CONFIG_ARCH_OMAP24XX
static struct map_desc omap24xx_io_desc[] __initdata = {
       ...
};
#endif

#ifdef CONFIG_ARCH_OMAP34XX
static struct map_desc omap34xx_io_desc[] __initdata = {
       ...
       };
#endif
       
void __init omap2_map_common_io(void)
{
 	if (cpu_is_omap24xx()) {
        	iotable_init(omap24xx_io_desc, ARRAY_SIZE(omap24xx_io_desc));
	} else if (cpu_is_omap34xx()) {
		iotable_init(omap34xx_io_desc, ARRAY_SIZE(omap34xx_io_desc));
	}
	...
}

We should actually have separate one for 2420 and 2430 too to avoid
ifdefs within the structs.

Regards,

Tony