Re: [PATCH 1/2] OMAP: Kill compile warnings

Dirk Behme
2007-05-26T05:38:01Z

Syed Mohammed, Khasim wrote:
>> That would be redundant:
>> 220 /* Get the debug Device */
>> 221 dbg_dev = &(pdev->dev);
>> already did that for you.. only, now the messages will show
>> "input:xyz.." instead of "omap_twl4030:xyz"..
>
> OK, thanks.
>
> Acked-by: x0khasim@ti.com

Okay, after 2 minutes thinking about what's so confusing here, I have
it now. We have two different patches with nearly identical subject.
The first one should fix a warning we already discussed under an other
subject. A answer to the second patch was sent under the subject of
the first one ;) Therefore some clarification as I understand it now:

We have two warnings:

1) Section mismatch with sys_timer

This is what "[PATCH 1/2] OMAP: Kill compile warnings" is about.

As mentioned by Tony this patch isn't correct and we will wait (as
discussed already earlier) until this is fixed by ignore list.

http://linux.omap.com/pipermail/linux-omap-open-source/2007-May/010087.html

http://linux.omap.com/pipermail/linux-omap-open-source/2007-May/010061.html

2) Warning in twl4030 keypad about dbg_dev

This is what "[PATCH 2/2] OMAP: Kill compile warnings" is about.

For this we already had an other subject in the list archives as well
"Compiler warning in omap-twl4030keypad.c".

Above Khasim acked it (with misleading subject ;) ) and I also think
it's okay

http://linux.omap.com/pipermail/linux-omap-open-source/2007-May/010086.html

Acked-by: Dirk Behme <dirk.behme@gmail.com>

Conclusion: For (1) we have to wait, for (2) please apply.

Hope that helps a little,

Dirk