Re: [PATCH 1/2] OMAP: Kill compile warnings

Tony Lindgren
2007-05-25T23:12:16Z

* nishanth menon <menon.nishanth@gmail.com> [070525 16:05]:
> Got the subject wrong last time.. Sorry..
> kill warning1: remove link to .init.text
> omap_timer refers to __init omap2_gp_timer_init function causing a warning
> while the linking is done
>
> Signed-off-by: Nishanth Menon <menon.nishanth@gmail.com>
> ---
> arch/arm/mach-omap2/timer-gp.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/timer-gp.c
> b/arch/arm/mach-omap2/timer-gp.c
> index 8f380a1..f4cf6fe 100644
> --- a/arch/arm/mach-omap2/timer-gp.c
> +++ b/arch/arm/mach-omap2/timer-gp.c
> @@ -175,6 +175,6 @@ static void __init omap2_gp_timer_init(void)
> omap2_gp_clocksource_init();
> }
>
> -struct sys_timer omap_timer = {
> - .init = omap2_gp_timer_init,
> +struct sys_timer omap_timer __initdata = {
> + .init = omap2_gp_timer_init,
> };
> --

This warning is wrong, and we cannot mark sys_timer as initdata. See
other mails related to this on this list. I'd assume this will get fixed
once sys_timer is added to the list of things to ignore.

Tony