From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: OMAP: 2430SDP: minor fixups for fb driver Date: Fri, 8 Jun 2007 03:28:07 -0700 Message-ID: <20070608102806.GK28556@atomide.com> References: <11810916331121-git-send-email-khilman@mvista.com> <11810916333338-git-send-email-khilman@mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <11810916333338-git-send-email-khilman@mvista.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: Kevin Hilman Cc: linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org * Kevin Hilman [070605 18:04]: > Remove redundant #defines > Fix LCD pixelclock to 5.4 MHz > > Signed-off-by: Hunyue Yau > Signed-off-by: Kevin Hilman > --- > drivers/video/omap/lcd_2430sdp.c | 8 ++------ > 1 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/video/omap/lcd_2430sdp.c b/drivers/video/omap/lcd_2430sdp.c > index 0c50d10..6e5b603 100644 > --- a/drivers/video/omap/lcd_2430sdp.c > +++ b/drivers/video/omap/lcd_2430sdp.c > @@ -31,14 +31,10 @@ > > #define LCD_PANEL_BACKLIGHT_GPIO 91 > #define LCD_PANEL_ENABLE_GPIO 154 > -#define H4_LCD_PIXCLOCK_MAX 185186 /* freq 5.4 MHz */ > +#define LCD_PIXCLOCK_MAX 5400 /* freq 5.4 MHz */ > #define PM_RECEIVER TWL4030_MODULE_PM_RECIEVER > #define ENABLE_VAUX2_DEDICATED 0x09 > #define ENABLE_VAUX2_DEV_GRP 0x20 > -#define TWL4030_VAUX2_DEV_GRP 0x1B > -#define TWL4030_VAUX2_DEDICATED 0x1E > -#define TWL4030_MODULE_PM_RECIEVER 0x13 > - > > > #define t2_out(c, r, v) twl4030_i2c_write_u8(c, r, v) > @@ -99,7 +95,7 @@ struct lcd_panel sdp2430_panel = { > .vfp = 2, /* lower_margin */ > .vbp = 7, /* upper_margin (8) - 1 */ > > - .pixel_clock = H4_LCD_PIXCLOCK_MAX, > + .pixel_clock = LCD_PIXCLOCK_MAX, > > .init = sdp2430_panel_init, > .cleanup = sdp2430_panel_cleanup, Pushing today. Tony