public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Woodruff, Richard" <r-woodruff2@ti.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: dss2 dvfs fix.
Date: Thu, 21 Jun 2007 04:47:14 -0700	[thread overview]
Message-ID: <20070621114712.GF20283@atomide.com> (raw)
In-Reply-To: <3B6D69C3A9EBCA4BA5DA60D91302742901403565@dlee13.ent.ti.com>

* Woodruff, Richard <r-woodruff2@ti.com> [070620 18:49]:
> Hi,
> 
> While testing low power refresh I noticed the DSS2 clock setting wasn't
> being perserved across DVFS changes.  The below makes sure to not change
> the source for DSS2.
> 
> Signed-off-by: Richard Woodruff  <r-woodruff2@ti.com>
> 
> diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
> index f6da2bd..a7792d3 100644
> --- a/arch/arm/mach-omap2/clock.c
> +++ b/arch/arm/mach-omap2/clock.c
> @@ -995,7 +995,7 @@ static int omap2_clk_set_parent(struct clk *clk,
> struct clk *new_parent)
>  /* Sets basic clocks based on the specified rate */
>  static int omap2_select_table_rate(struct clk * clk, unsigned long
> rate)
>  {
> -	u32 flags, cur_rate, done_rate, bypass = 0;
> +	u32 flags, cur_rate, done_rate, bypass = 0, tmp;
>  	u8 cpu_mask = 0;
>  	struct prcm_config *prcm;
>  	unsigned long found_speed = 0;
> @@ -1056,7 +1056,8 @@ static int omap2_select_table_rate(struct clk *
> clk, unsigned long rate)
>  		cm_write_mod_reg(prcm->cm_clksel_gfx, GFX_MOD,
> CM_CLKSEL);
>  
>  		/* Major subsystem dividers */
> -		cm_write_mod_reg(prcm->cm_clksel1_core, CORE_MOD,
> CM_CLKSEL1);
> +		tmp = cm_read_mod_reg(CORE_MOD, CM_CLKSEL1) & 0x2000;
> +		cm_write_mod_reg(prcm->cm_clksel1_core | tmp, CORE_MOD,
> CM_CLKSEL1);
>  		if (cpu_is_omap2430())
>  			cm_write_mod_reg(prcm->cm_clksel_mdm,
>  					 OMAP2430_MDM_MOD, CM_CLKSEL);

Thanks, pushing today. Patch was wrapped BTW...

Tony

      reply	other threads:[~2007-06-21 11:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-21  1:48 dss2 dvfs fix Woodruff, Richard
2007-06-21 11:47 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070621114712.GF20283@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=r-woodruff2@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox