public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Compile fix OMAP1 DMA V4 Base
@ 2007-06-23 19:48 Ragner Magalhaes
  2007-06-25  9:27 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Ragner Magalhaes @ 2007-06-23 19:48 UTC (permalink / raw)
  To: x0khasim; +Cc: linux-omap-open-source

From: Ragner Magalhaes <ragner.magalhaes@indt.org.br>

when OMAP1, OMAP_DMA4_BASE(DMA V4 Base) is not defined causing the follow complile error:

arch/arm/plat-omap/dma.c: In function 'omap_set_dma_src_params':
arch/arm/plat-omap/dma.c:273: error: 'OMAP_DMA4_BASE' undeclared (first use in this function)
arch/arm/plat-omap/dma.c:273: error: (Each undeclared identifier is reported only once
arch/arm/plat-omap/dma.c:273: error: for each function it appears in.)
...
make[1]: *** [arch/arm/plat-omap/dma.o] Error 1

Signed-off-by: Ragner Magalhaes <ragner.magalhaes@indt.org.br>
---

 include/asm-arm/arch-omap/dma.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/asm-arm/arch-omap/dma.h b/include/asm-arm/arch-omap/dma.h
index e9546df..fa898c8 100644
--- a/include/asm-arm/arch-omap/dma.h
+++ b/include/asm-arm/arch-omap/dma.h
@@ -49,6 +49,8 @@
 #define OMAP_DMA4_BASE			(L4_34XX_BASE + 0x56000)
 #elif defined(CONFIG_ARCH_OMAP2)
 #define OMAP_DMA4_BASE			(L4_24XX_BASE + 0x56000)
+#else
+#define OMAP_DMA4_BASE			(L4_24XX_BASE + 0x56000)
 #endif
 
 #define OMAP_DMA4_REVISION		(OMAP_DMA4_BASE + 0x00)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Compile fix OMAP1 DMA V4 Base
  2007-06-23 19:48 [PATCH] Compile fix OMAP1 DMA V4 Base Ragner Magalhaes
@ 2007-06-25  9:27 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2007-06-25  9:27 UTC (permalink / raw)
  To: Ragner Magalhaes; +Cc: linux-omap-open-source

* Ragner Magalhaes <ragner.magalhaes@indt.org.br> [070623 13:00]:
> From: Ragner Magalhaes <ragner.magalhaes@indt.org.br>
> 
> when OMAP1, OMAP_DMA4_BASE(DMA V4 Base) is not defined causing the follow complile error:
> 
> arch/arm/plat-omap/dma.c: In function 'omap_set_dma_src_params':
> arch/arm/plat-omap/dma.c:273: error: 'OMAP_DMA4_BASE' undeclared (first use in this function)
> arch/arm/plat-omap/dma.c:273: error: (Each undeclared identifier is reported only once
> arch/arm/plat-omap/dma.c:273: error: for each function it appears in.)
> ...
> make[1]: *** [arch/arm/plat-omap/dma.o] Error 1
> 
> Signed-off-by: Ragner Magalhaes <ragner.magalhaes@indt.org.br>
> ---
> 
>  include/asm-arm/arch-omap/dma.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/asm-arm/arch-omap/dma.h b/include/asm-arm/arch-omap/dma.h
> index e9546df..fa898c8 100644
> --- a/include/asm-arm/arch-omap/dma.h
> +++ b/include/asm-arm/arch-omap/dma.h
> @@ -49,6 +49,8 @@
>  #define OMAP_DMA4_BASE			(L4_34XX_BASE + 0x56000)
>  #elif defined(CONFIG_ARCH_OMAP2)
>  #define OMAP_DMA4_BASE			(L4_24XX_BASE + 0x56000)
> +#else
> +#define OMAP_DMA4_BASE			(L4_24XX_BASE + 0x56000)
>  #endif
>  
>  #define OMAP_DMA4_REVISION		(OMAP_DMA4_BASE + 0x00)

Thanks, I've applied it slightly modified to replace the second elif
with just else.

Tony

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-06-25  9:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-23 19:48 [PATCH] Compile fix OMAP1 DMA V4 Base Ragner Magalhaes
2007-06-25  9:27 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox