Re: [PATCH] Pre 3430 patch for io.c map table cleanup

[Tony Lindgren <tony@atomide.com>]

* Syed Mohammed, Khasim <x0khasim@ti.com> [070621 06:13]:
> Hi Tony,
> 
> >> +#if defined(CONFIG_ARCH_OMAP2420)
> >> +	iotable_init(omap24xx_io_desc, ARRAY_SIZE(omap24xx_io_desc));
> >> +	iotable_init(omap242x_io_desc, ARRAY_SIZE(omap242x_io_desc));
> >> +#elif defined(CONFIG_ARCH_OMAP2430)
> >> +	iotable_init(omap24xx_io_desc, ARRAY_SIZE(omap24xx_io_desc));
> >> +	iotable_init(omap243x_io_desc, ARRAY_SIZE(omap243x_io_desc));
> >> +#endif
> >>  	/* Normally devicemaps_init() would flush caches and tlb after
> >>  	 * mdesc->map_io(), but we must also do it here because of the CPU
> >>  	 * revision check below.
> >
> >You don't need the #defines here. This adds yet another artificial
> >barrier to compiling in both.
> >
> >Use cpu_is_omap34xx() et al to init them.
> 
> We had discussion on this topic and I had communicated why defines are required.

Oh yeah, that's right, sorry I forgot about the cpu detection issue.

> Let me know your views on the same.

Yes, I'll apply your current patch and we'll deal with the cpu
detection issues later on.

Tony