public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Ragner Magalhaes <ragner.magalhaes@indt.org.br>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] Compile fix OMAP1 DMA V4 Base
Date: Mon, 25 Jun 2007 02:27:33 -0700	[thread overview]
Message-ID: <20070625092733.GE32406@atomide.com> (raw)
In-Reply-To: <20070623194855.22272.15633.stgit@localhost.localdomain>

* Ragner Magalhaes <ragner.magalhaes@indt.org.br> [070623 13:00]:
> From: Ragner Magalhaes <ragner.magalhaes@indt.org.br>
> 
> when OMAP1, OMAP_DMA4_BASE(DMA V4 Base) is not defined causing the follow complile error:
> 
> arch/arm/plat-omap/dma.c: In function 'omap_set_dma_src_params':
> arch/arm/plat-omap/dma.c:273: error: 'OMAP_DMA4_BASE' undeclared (first use in this function)
> arch/arm/plat-omap/dma.c:273: error: (Each undeclared identifier is reported only once
> arch/arm/plat-omap/dma.c:273: error: for each function it appears in.)
> ...
> make[1]: *** [arch/arm/plat-omap/dma.o] Error 1
> 
> Signed-off-by: Ragner Magalhaes <ragner.magalhaes@indt.org.br>
> ---
> 
>  include/asm-arm/arch-omap/dma.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/asm-arm/arch-omap/dma.h b/include/asm-arm/arch-omap/dma.h
> index e9546df..fa898c8 100644
> --- a/include/asm-arm/arch-omap/dma.h
> +++ b/include/asm-arm/arch-omap/dma.h
> @@ -49,6 +49,8 @@
>  #define OMAP_DMA4_BASE			(L4_34XX_BASE + 0x56000)
>  #elif defined(CONFIG_ARCH_OMAP2)
>  #define OMAP_DMA4_BASE			(L4_24XX_BASE + 0x56000)
> +#else
> +#define OMAP_DMA4_BASE			(L4_24XX_BASE + 0x56000)
>  #endif
>  
>  #define OMAP_DMA4_REVISION		(OMAP_DMA4_BASE + 0x00)

Thanks, I've applied it slightly modified to replace the second elif
with just else.

Tony

      reply	other threads:[~2007-06-25  9:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-23 19:48 [PATCH] Compile fix OMAP1 DMA V4 Base Ragner Magalhaes
2007-06-25  9:27 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070625092733.GE32406@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=ragner.magalhaes@indt.org.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox