public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: David Brownell <david-b@pacbell.net>
Cc: Linux OMAP <linux-omap-open-source@linux.omap.com>
Subject: Re: Common code for TSC 2101 and 2102
Date: Fri, 10 Aug 2007 00:29:13 -0700	[thread overview]
Message-ID: <20070810072912.GE8658@atomide.com> (raw)
In-Reply-To: <200707131304.24074.david-b@pacbell.net>

* David Brownell <david-b@pacbell.net> [070713 13:05]:
> On Friday 13 July 2007, andrzej zaborowski wrote:
> 
> > > do not add new typedefs
> > > #1796: FILE: include/linux/spi/tsc210x.h:54:
> > > +typedef void (*tsc210x_touch_t)(void *context, int touching);
> > >
> > > do not add new typedefs
> > > #1797: FILE: include/linux/spi/tsc210x.h:55:
> > > +typedef void (*tsc210x_coords_t)(void *context, int x, int y, int z1, int z2);
> > >
> > > do not add new typedefs
> > > #1798: FILE: include/linux/spi/tsc210x.h:56:
> > > +typedef void (*tsc210x_ports_t)(void *context, int bat[], int aux[]);
> > >
> > > do not add new typedefs
> > > #1799: FILE: include/linux/spi/tsc210x.h:57:
> > > +typedef void (*tsc210x_temp_t)(void *context, int temp);
> > 
> > I wonder what is used instead.
> 
> I think the "no new typedefs" rule gets relaxed for function
> call prototypes.  But to answer your question:  it's usually
> more clear to just put the function prototype into the relevant
> type declarator than to define a new type.

I'll be pushing Andrzej's patch today.

Tony

  reply	other threads:[~2007-08-10  7:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-04 13:44 Common code for TSC 2101 and 2102 andrzej zaborowski
2007-07-13  6:46 ` Trilok Soni
2007-07-13  7:10   ` Trilok Soni
2007-07-13 19:29     ` andrzej zaborowski
2007-07-13 20:04       ` David Brownell
2007-08-10  7:29         ` Tony Lindgren [this message]
2007-08-11  3:04           ` David Brownell
2007-08-13  7:05             ` Tony Lindgren
2007-08-14  5:34               ` David Brownell
2007-09-23 22:37                 ` andrzej zaborowski
2007-08-14  5:38               ` [patch 2.6.23-rc2-omap1] tsc210x cleanup David Brownell
2007-08-15 10:54                 ` Tony Lindgren
2007-08-14  5:40               ` [patch 2.6.23-rc2-omap1] H4 support for tsc210x David Brownell
2007-08-14  6:45                 ` David Brownell
2007-08-15 10:54                   ` Tony Lindgren
2007-07-13 18:38   ` Common code for TSC 2101 and 2102 David Brownell
2007-07-15 20:18 ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070810072912.GE8658@atomide.com \
    --to=tony@atomide.com \
    --cc=david-b@pacbell.net \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox