public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Syed Mohammed, Khasim" <x0khasim@ti.com>
Cc: Tuukka.Tikkanen@elektrobit.com,
	linux-omap-open-source@linux.omap.com, kmpark@infradead.org
Subject: Re: Why does it increase the dsor value in MMC?
Date: Fri, 10 Aug 2007 00:48:22 -0700	[thread overview]
Message-ID: <20070810074821.GI8658@atomide.com> (raw)
In-Reply-To: <9C23CDD79DA20A479D4615857B2E2C47013BFAF2@dlee13.ent.ti.com>

* Syed Mohammed, Khasim <x0khasim@ti.com> [070701 20:05]:
> Hi,
> 
> >Then how about to append the following code?
> >
> >/* If the dsor is zero, we increase the dsor value to enable the clock */
> >if (dsor == 0)
> >	dsor++;
> >
> >It not only assigns the correct dsor values, but also enables the other
> >platform.
> >
> 
> In TI's code we do the following, we don't add the extra dsor increment. This works for 2420 / 2430 and 3430 processors for all different types of MMC/SD cards.
>        if (ios->clock) {
>                 /* Enable MMC_SD_CLK */
>                 dsor = OMAP_MMC_MASTER_CLOCK / ios->clock;
>                 if (dsor < 1)
>                         dsor = 1;
> 
>                 if (OMAP_MMC_MASTER_CLOCK / dsor > ios->clock)
>                         dsor++;
> 
>                 if (dsor > 250)
>                         dsor = 250;
>         }
> 
> As Tuukka suggested we might have to check the history and see if this line was mistakenly added. I was not able to browse history through muru.com / source.mvista.com looks like some server problem.

I'll remove the extra dsor++ line as suggested. Let's see
if anything breaks.

Tony

      reply	other threads:[~2007-08-10  7:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-29  9:52 Why does it increase the dsor value in MMC? Kyungmin Park
2007-06-29 14:15 ` Tuukka.Tikkanen
2007-06-29 15:28   ` Syed Mohammed, Khasim
2007-07-02  2:14     ` Kyungmin Park
2007-07-02  3:04       ` Syed Mohammed, Khasim
2007-08-10  7:48         ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070810074821.GI8658@atomide.com \
    --to=tony@atomide.com \
    --cc=Tuukka.Tikkanen@elektrobit.com \
    --cc=kmpark@infradead.org \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=x0khasim@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox