[PATCH] To Cleanup TWL-Core driver

[PATCH] To Cleanup TWL-Core driver

[Syed Mohammed, Khasim]

Patch to cleanup few spellings in TWL4030 Core and export TWLGPIO APIs

Signed-off-by: Syed Mohammed Khasim  <x0khasim@ti.com>

Files:
 drivers/i2c/chips/twl4030_core.c
 include/asm-arm/arch-omap/twl4030.h

===========================================================================

diff -purN linux-omap/drivers/i2c/chips/twl4030_core.c lin_for_mmc/drivers/i2c/chips/twl4030_core.c
--- linux-omap/drivers/i2c/chips/twl4030_core.c	2007-06-08 08:09:38.000000000 -0500
+++ lin_for_mmc/drivers/i2c/chips/twl4030_core.c	2007-07-18 12:02:56.000000000 -0500
@@ -111,7 +111,7 @@
 #define TWL4030_BASEADD_BACKUP		0x0014
 #define TWL4030_BASEADD_INT		0x002E
 #define TWL4030_BASEADD_PM_MASTER	0x0036
-#define TWL4030_BASEADD_PM_RECIEVER	0x005B
+#define TWL4030_BASEADD_PM_RECEIVER	0x005B
 #define TWL4030_BASEADD_RTC		0x001C
 #define TWL4030_BASEADD_SECURED_REG	0x0000
 
@@ -189,7 +189,7 @@ static struct twl4030mapping twl4030_map
 	{ TWL4030_SLAVENUM_NUM3, TWL4030_BASEADD_BACKUP },
 	{ TWL4030_SLAVENUM_NUM3, TWL4030_BASEADD_INT },
 	{ TWL4030_SLAVENUM_NUM3, TWL4030_BASEADD_PM_MASTER },
-	{ TWL4030_SLAVENUM_NUM3, TWL4030_BASEADD_PM_RECIEVER },
+	{ TWL4030_SLAVENUM_NUM3, TWL4030_BASEADD_PM_RECEIVER },
 	{ TWL4030_SLAVENUM_NUM3, TWL4030_BASEADD_RTC },
 	{ TWL4030_SLAVENUM_NUM3, TWL4030_BASEADD_SECURED_REG },
 };

diff -purN linux-omap/include/asm-arm/arch-omap/twl4030.h lin_for_mmc/include/asm-arm/arch-omap/twl4030.h
--- linux-omap/include/asm-arm/arch-omap/twl4030.h	2007-05-23 23:29:31.000000000 -0500
+++ lin_for_mmc/include/asm-arm/arch-omap/twl4030.h	2007-07-25 18:17:19.000000000 -0500
@@ -48,7 +48,7 @@
 #define TWL4030_MODULE_BACKUP		0x10
 #define TWL4030_MODULE_INT		0x11
 #define TWL4030_MODULE_PM_MASTER	0x12
-#define TWL4030_MODULE_PM_RECIEVER	0x13
+#define TWL4030_MODULE_PM_RECEIVER	0x13
 #define TWL4030_MODULE_RTC		0x14
 #define TWL4030_MODULE_SECURED_REG	0x15
 
@@ -106,4 +106,13 @@ int twl4030_i2c_read_u8(u8 mod_no, u8* v
 int twl4030_i2c_write(u8 mod_no, u8 * value, u8 reg, u8 num_bytes);
 int twl4030_i2c_read(u8 mod_no, u8 * value, u8 reg, u8 num_bytes);
 
+/*
+ * Exported TWL4030 GPIO APIs
+ */
+int twl4030_get_gpio_datain(int gpio);
+int twl4030_request_gpio(int gpio);
+int twl4030_set_gpio_edge_ctrl(int gpio, int edge);
+int twl4030_set_gpio_debounce(int gpio, int enable);
+int twl4030_free_gpio(int gpio);
+
 #endif /* End of __TWL4030_H */

Re: [PATCH] To Cleanup TWL-Core driver

[Nishanth Menon]

Syed Mohammed, Khasim stated on 7/25/2007 7:19 PM:
> diff -purN linux-omap/include/asm-arm/arch-omap/twl4030.h lin_for_mmc/include/asm-arm/arch-omap/twl4030.h
>  
> +/*
> + * Exported TWL4030 GPIO APIs
> + */
> +int twl4030_get_gpio_datain(int gpio);
> +int twl4030_request_gpio(int gpio);
> +int twl4030_set_gpio_edge_ctrl(int gpio, int edge);
> +int twl4030_set_gpio_debounce(int gpio, int enable);
> +int twl4030_free_gpio(int gpio);
> +
>  #endif /* End of __TWL4030_H */
> _______________________________________________
>   
I think twl4030.h is a shared header & twlgpio driver is independent of
twl core driver. if i disable this, there wont be even a warning for the
file using this apis. why dont we cover them with the CONFIG macro for
twl gpio? - Am not sure if that is acceptable as per coding standards OR
if we need to create another shared header??...
Regards,
Nishanth Menon

Re: [PATCH] To Cleanup TWL-Core driver

[Tony Lindgren]

* Nishanth Menon <menon.nishanth@gmail.com> [070726 04:21]:
> Syed Mohammed, Khasim stated on 7/25/2007 7:19 PM:
> > diff -purN linux-omap/include/asm-arm/arch-omap/twl4030.h lin_for_mmc/include/asm-arm/arch-omap/twl4030.h
> >  
> > +/*
> > + * Exported TWL4030 GPIO APIs
> > + */
> > +int twl4030_get_gpio_datain(int gpio);
> > +int twl4030_request_gpio(int gpio);
> > +int twl4030_set_gpio_edge_ctrl(int gpio, int edge);
> > +int twl4030_set_gpio_debounce(int gpio, int enable);
> > +int twl4030_free_gpio(int gpio);
> > +
> >  #endif /* End of __TWL4030_H */
> > _______________________________________________
> >   
> I think twl4030.h is a shared header & twlgpio driver is independent of
> twl core driver. if i disable this, there wont be even a warning for the
> file using this apis. why dont we cover them with the CONFIG macro for
> twl gpio? - Am not sure if that is acceptable as per coding standards OR
> if we need to create another shared header??...

Do you have a patch to combine the headers?

Pushing Khasim's patch today.

Tony