* [PATCH 1/1] ARM: OMAP: Fix inconsistency of completion in retu-rtc
@ 2007-08-15 6:40 Hiroshi.DOYU
2007-08-15 10:56 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Hiroshi.DOYU @ 2007-08-15 6:40 UTC (permalink / raw)
To: linux-omap-open-source; +Cc: Hiroshi DOYU
From: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
There was the case that multiple users can wait for completion.
Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
---
drivers/cbus/retu-rtc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/cbus/retu-rtc.c b/drivers/cbus/retu-rtc.c
index b36fd06..5d43520 100644
--- a/drivers/cbus/retu-rtc.c
+++ b/drivers/cbus/retu-rtc.c
@@ -328,7 +328,7 @@ DECLARE_WORK(retu_rtca_work, retu_rtca_expired);
static void retu_rtcs_interrupt(unsigned long unused)
{
retu_ack_irq(RETU_INT_RTCS);
- complete(&retu_rtc_sync);
+ complete_all(&retu_rtc_sync);
}
static void retu_rtca_interrupt(unsigned long unused)
@@ -435,7 +435,7 @@ static struct platform_device retu_rtc_device = {
/* This function provides syncronization with the RTCS interrupt handler */
static void retu_rtc_barrier(void)
{
- init_completion(&retu_rtc_sync);
+ INIT_COMPLETION(retu_rtc_sync);
retu_ack_irq(RETU_INT_RTCS);
retu_enable_irq(RETU_INT_RTCS);
wait_for_completion(&retu_rtc_sync);
--
1.5.3.rc4.16.ga76c2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] ARM: OMAP: Fix inconsistency of completion in retu-rtc
2007-08-15 6:40 [PATCH 1/1] ARM: OMAP: Fix inconsistency of completion in retu-rtc Hiroshi.DOYU
@ 2007-08-15 10:56 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2007-08-15 10:56 UTC (permalink / raw)
To: Hiroshi.DOYU; +Cc: linux-omap-open-source
* Hiroshi.DOYU@nokia.com <Hiroshi.DOYU@nokia.com> [070814 23:52]:
> From: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
>
> There was the case that multiple users can wait for completion.
>
> Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> ---
> drivers/cbus/retu-rtc.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cbus/retu-rtc.c b/drivers/cbus/retu-rtc.c
> index b36fd06..5d43520 100644
> --- a/drivers/cbus/retu-rtc.c
> +++ b/drivers/cbus/retu-rtc.c
> @@ -328,7 +328,7 @@ DECLARE_WORK(retu_rtca_work, retu_rtca_expired);
> static void retu_rtcs_interrupt(unsigned long unused)
> {
> retu_ack_irq(RETU_INT_RTCS);
> - complete(&retu_rtc_sync);
> + complete_all(&retu_rtc_sync);
> }
>
> static void retu_rtca_interrupt(unsigned long unused)
> @@ -435,7 +435,7 @@ static struct platform_device retu_rtc_device = {
> /* This function provides syncronization with the RTCS interrupt handler */
> static void retu_rtc_barrier(void)
> {
> - init_completion(&retu_rtc_sync);
> + INIT_COMPLETION(retu_rtc_sync);
> retu_ack_irq(RETU_INT_RTCS);
> retu_enable_irq(RETU_INT_RTCS);
> wait_for_completion(&retu_rtc_sync);
> --
Pushing today.
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-15 10:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-15 6:40 [PATCH 1/1] ARM: OMAP: Fix inconsistency of completion in retu-rtc Hiroshi.DOYU
2007-08-15 10:56 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox