public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Felipe Balbi <felipebalbi@users.sourceforge.net>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] ARM: OMAP: Fix warning in plat_uds.c
Date: Fri, 17 Aug 2007 11:30:21 -0700	[thread overview]
Message-ID: <200708171130.21974.david-b@pacbell.net> (raw)
In-Reply-To: <31e679430708171114o565ee910o2002a0bf98865c90@mail.gmail.com>

On Friday 17 August 2007, Felipe Balbi wrote:
> Hi,
> 
> On 8/17/07, David Brownell <david-b@pacbell.net> wrote:
> > > this doesn't look right since any device can issue SRP. It's better
> > > for you to use it somewhere on DaVinci.
> >
> > That "issue SRP" attribute has no business being specific to any
> > particular platform.
> >
> 
> This is needed during USB OTG Compliance program... and it looks to me
> really architecture dependent, if you have a better way for doing
> this, please tell me and I'll try it.

Pure devices can issue SRP, hardware allowing.  So it's incorrect
to have this #ifdeffed for OTG.  That's in addition to the compiler
warnings you get when building with a pure host...

  reply	other threads:[~2007-08-17 18:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-17 15:43 [PATCH] ARM: OMAP: Fix warning in plat_uds.c Dirk Behme
2007-08-17 16:12 ` Felipe Balbi
2007-08-17 16:39   ` Dirk Behme
2007-08-17 16:57     ` David Brownell
2007-08-17 18:14       ` Felipe Balbi
2007-08-17 18:30         ` David Brownell [this message]
2007-08-17 20:36           ` Felipe Balbi
2007-08-17 21:02             ` David Brownell
2007-08-20  6:51               ` Dirk Behme
2007-08-20  8:41                 ` David Brownell
2007-08-20  9:59                   ` Dirk Behme
2007-08-20 18:10                     ` David Brownell
2007-08-21  7:24                       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200708171130.21974.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=felipebalbi@users.sourceforge.net \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox