RE: [PATCH 28/28] omap2 clock: handle (almost) all clock autoidling viathe clock framework

Paul Walmsley
2007-08-27T07:39:47Z

Hello Richard,

On Wed, 22 Aug 2007, Woodruff, Richard wrote:

> Actually the patch as I sent it was completely self contained it was
> done that way just to be fast :) Changing it to use the macros is no
> problem.

Cool.

> I'd probably shy away from using the clock frame work to turn on and off
> each clock via name string though. They would result way too much code.

Yeah, in the autoidle patch I added a clk_allow_idle_all() function that
just walked down the clock list and called ->allow_idle() on each clock
that had one. This avoided the search by name string. Nevertheless, I
think I will set that patch aside for now, it's not critical; maybe we'll
take another look at it after the 3430 clock code shows up.

> The OCP registers are in each modules address space. An example of what
> I was talking about is GTP1.TIOCP_CFG:0x48318010.

Indeed, my mistake; not sure what register I was looking at when I wrote
the earlier post.

> On OMAP3 if you are using software control methods you may need to set
> these in a particular way to ensure data has cleared before shutting
> down the module. I don't expect control at this granularity makes sense
> for our typical usage, but if you are doing full hardware dependency for
> idling it is relevant.

Is this only if we set *_SYSCONFIG.AUTOIDLE to force-idle?

- Paul