[PATCH] ARM: OMAP: OMAP2 McSPI code cleanup

[PATCH] ARM: OMAP: OMAP2 McSPI code cleanup

[Kyungmin Park]

ARM: OMAP: OMAP2 McSPI code cleanup

Remove unused variable & write space

Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
--
diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c
index 6b357cd..3cdab13 100644
--- a/drivers/spi/omap2_mcspi.c
+++ b/drivers/spi/omap2_mcspi.c
@@ -645,7 +645,7 @@ static int omap2_mcspi_setup(struct spi_device *spi)
 
 	clk_enable(mcspi->ick);
 	clk_enable(mcspi->fck);
-	ret =  omap2_mcspi_setup_transfer(spi, NULL);
+	ret = omap2_mcspi_setup_transfer(spi, NULL);
 	clk_disable(mcspi->fck);
 	clk_disable(mcspi->ick);
 
@@ -693,7 +693,6 @@ static void omap2_mcspi_work(struct work_struct *work)
 		struct spi_device		*spi;
 		struct spi_transfer		*t = NULL;
 		int				cs_active = 0;
-		struct omap2_mcspi_device_config *conf;
 		struct omap2_mcspi_cs		*cs;
 		int				par_override = 0;
 		int				status = 0;
@@ -706,7 +705,6 @@ static void omap2_mcspi_work(struct work_struct *work)
 		spin_unlock_irq(&mcspi->lock);
 
 		spi = m->spi;
-		conf = spi->controller_data;
 		cs = spi->controller_state;
 
 		omap2_mcspi_set_enable(spi, 1);

Re: [PATCH] ARM: OMAP: OMAP2 McSPI code cleanup

[David Brownell]

On Friday 17 August 2007, you wrote:
> ARM: OMAP: OMAP2 McSPI code cleanup

SPI patches don't merge via the ARM or OMAP patch streams...

If you just send them for the OMAP tree they won't necessarily
go upstream unless the SPI maintainer happens to notice them.


> Remove unused variable & write space
> 
> ...

Re: [PATCH] ARM: OMAP: OMAP2 McSPI code cleanup

[Tony Lindgren]

* David Brownell <david-b@pacbell.net> [070817 08:52]:
> On Friday 17 August 2007, you wrote:
> > ARM: OMAP: OMAP2 McSPI code cleanup
> 
> SPI patches don't merge via the ARM or OMAP patch streams...
> 
> If you just send them for the OMAP tree they won't necessarily
> go upstream unless the SPI maintainer happens to notice them.

Yeah, we must get more active in general on the lists with I2C,
MMC, framebuffer...

> > Remove unused variable & write space

I'll push this to linux-omap while waiting for this to trickle
down from the mainline kernel.

Tony