* [PATCH] ARM: OMAP: musb_vbus_store(): dont exit with spinlock held
@ 2007-08-31 23:29 Kevin Hilman
2007-09-01 2:15 ` David Brownell
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Hilman @ 2007-08-31 23:29 UTC (permalink / raw)
To: linux-omap-open-source
Signed-off-by: Kevin Hilman <khilman@mvista.com>
---
drivers/usb/musb/musb_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: dev/drivers/usb/musb/musb_core.c
===================================================================
--- dev.orig/drivers/usb/musb/musb_core.c
+++ dev/drivers/usb/musb/musb_core.c
@@ -1683,11 +1683,12 @@ musb_vbus_store(struct device *dev, stru
unsigned long flags;
unsigned long val;
- spin_lock_irqsave(&musb->lock, flags);
if (sscanf(buf, "%lu", &val) < 1) {
printk(KERN_ERR "Invalid VBUS timeout ms value\n");
return -EINVAL;
}
+
+ spin_lock_irqsave(&musb->lock, flags);
musb->a_wait_bcon = val;
if (musb->xceiv.state == OTG_STATE_A_WAIT_BCON)
musb->is_active = 0;
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: OMAP: musb_vbus_store(): dont exit with spinlock held
2007-08-31 23:29 [PATCH] ARM: OMAP: musb_vbus_store(): dont exit with spinlock held Kevin Hilman
@ 2007-09-01 2:15 ` David Brownell
2007-09-17 18:26 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: David Brownell @ 2007-09-01 2:15 UTC (permalink / raw)
To: linux-omap-open-source, khilman
> From linux-omap-open-source-bounces+david-b=pacbell.net@linux.omap.com Fri Aug 31 16:33:11 2007
> Date: Fri, 31 Aug 2007 16:29:22 -0700
> From: Kevin Hilman <khilman@mvista.com>
> To: linux-omap-open-source@linux.omap.com
> Subject: [PATCH] ARM: OMAP: musb_vbus_store(): dont exit with spinlock held
>
> Signed-off-by: Kevin Hilman <khilman@mvista.com>
Ack.
> ---
> drivers/usb/musb/musb_core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: dev/drivers/usb/musb/musb_core.c
> ===================================================================
> --- dev.orig/drivers/usb/musb/musb_core.c
> +++ dev/drivers/usb/musb/musb_core.c
> @@ -1683,11 +1683,12 @@ musb_vbus_store(struct device *dev, stru
> unsigned long flags;
> unsigned long val;
>
> - spin_lock_irqsave(&musb->lock, flags);
> if (sscanf(buf, "%lu", &val) < 1) {
> printk(KERN_ERR "Invalid VBUS timeout ms value\n");
> return -EINVAL;
> }
> +
> + spin_lock_irqsave(&musb->lock, flags);
> musb->a_wait_bcon = val;
> if (musb->xceiv.state == OTG_STATE_A_WAIT_BCON)
> musb->is_active = 0;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: OMAP: musb_vbus_store(): dont exit with spinlock held
2007-09-01 2:15 ` David Brownell
@ 2007-09-17 18:26 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2007-09-17 18:26 UTC (permalink / raw)
To: David Brownell; +Cc: linux-omap-open-source
* David Brownell <david-b@pacbell.net> [070831 19:15]:
> > From linux-omap-open-source-bounces+david-b=pacbell.net@linux.omap.com Fri Aug 31 16:33:11 2007
> > Date: Fri, 31 Aug 2007 16:29:22 -0700
> > From: Kevin Hilman <khilman@mvista.com>
> > To: linux-omap-open-source@linux.omap.com
> > Subject: [PATCH] ARM: OMAP: musb_vbus_store(): dont exit with spinlock held
> >
> > Signed-off-by: Kevin Hilman <khilman@mvista.com>
>
> Ack.
>
> > ---
> > drivers/usb/musb/musb_core.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > Index: dev/drivers/usb/musb/musb_core.c
> > ===================================================================
> > --- dev.orig/drivers/usb/musb/musb_core.c
> > +++ dev/drivers/usb/musb/musb_core.c
> > @@ -1683,11 +1683,12 @@ musb_vbus_store(struct device *dev, stru
> > unsigned long flags;
> > unsigned long val;
> >
> > - spin_lock_irqsave(&musb->lock, flags);
> > if (sscanf(buf, "%lu", &val) < 1) {
> > printk(KERN_ERR "Invalid VBUS timeout ms value\n");
> > return -EINVAL;
> > }
> > +
> > + spin_lock_irqsave(&musb->lock, flags);
> > musb->a_wait_bcon = val;
> > if (musb->xceiv.state == OTG_STATE_A_WAIT_BCON)
> > musb->is_active = 0;
This too, sorry for the delay I guess I forgot to push these earlier.
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-09-17 18:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-31 23:29 [PATCH] ARM: OMAP: musb_vbus_store(): dont exit with spinlock held Kevin Hilman
2007-09-01 2:15 ` David Brownell
2007-09-17 18:26 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox