Re: [PATCH RFC] arch/arm/plat-omap/devices.c

[Tony Lindgren <tony@atomide.com>]

Hi,

* Luís Cargnini <lvcargnini@gmail.com> [070918 13:34]:
> --- linux-omap-2.6/arch/arm/plat-omap/devices.c 2007-08-28 01:01:
> 50.502065325 -0300
> +++ linux-omap-2.6.23-instramed/arch/arm/plat-omap/devices.c    2007-09-18
> 15:05:44.748685528 -0300
> @@ -25,6 +25,26 @@
>  #include <asm/arch/gpio.h>
>  #include <asm/arch/menelaus.h>
> 
> +/*-------------------------------------------------------------------------*/
> +/**
> + * 18/09/2007 - 14:35 - 03:00GMT
> + * lvcargnini@ieee.org
> + * Luis Vitorio modifications for devices.c
> + * added this to fix some bugs founded for mmc and possible speed-up
> + * enhancements removing unecessary code, for some plataforms
> + * why test if cpu_is_2420 on the fly ????
> + */
> +
> +#if defined(CONFIG_ARCH_OMAP16XX)
> +#include <asm/arch/omap16xx.h>
> +#elif defined(CONFIG_ARCH_OMAP24XX)
> +#include <asm/arch/omap24xx.h>
> +#elif defined(CONFIG_ARCH_OMAP34XX)
> +#include <asm/arch/omap34xx.h>
> +#endif
> +
> +/*-------------------------------------------------------------------------*/
> +
>  #if    defined(CONFIG_OMAP_DSP) || defined(CONFIG_OMAP_DSP_MODULE)
> 
>  #include "../plat-omap/dsp/dsp_common.h"

We should just include all the headers we need, no need to ifdef them
out.

There are no real reasons why we could not compile in all the omap
kernels into one binary now that gcc supports mixing in later assembly
code. Adding ifdefs there will make compiling in support for various
omaps harder. (We can already compile in 15xx and 16xx).

Please also leave out changelog type comments, they will show up in
the git repository. Also leave out any formatting changes, they make
it harder to see what you're fixing. See the following under
Documentation in your Linux tree:

Documentation/SubmittingPatches
Documentation/SubmittingDrivers
Documentation/SubmitChecklist

Regards,

Tony