Re: [PATCH 04/14] MMC: OMAP: Power functions modified to MMC multislot support

[Tony Lindgren <tony@atomide.com>]

Hi,

* Carlos Aguiar <carlos.aguiar@indt.org.br> [070920 08:05]:
> From: Juha Yrjola <juha.yrjola@solidboot.com>
> 
> Modifications at power functions to MMC multislot support. This patch
> also move board-specific code out of MMC OMAP driver.
> 
> Signed-off-by: Juha Yrjola <juha.yrjola@solidboot.com>
> Signed-off-by: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
> ---
>  drivers/mmc/host/omap.c |   88 ++++++++++++++++++-----------------------------
>  1 files changed, 34 insertions(+), 54 deletions(-)
> 
> @@ -1090,23 +1063,29 @@ static void mmc_omap_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>  	int i, dsor;
>  
>  	dsor = mmc_omap_calc_divisor(mmc, ios);
> -	host->bus_mode = ios->bus_mode;
> -	host->hw_bus_mode = host->bus_mode;
> +
> +	mmc_omap_select_slot(slot, 0);
> +
> +	if (ios->vdd != slot->vdd)
> +		slot->vdd = ios->vdd;
>  
>  	switch (ios->power_mode) {
>  	case MMC_POWER_OFF:
> -		mmc_omap_power(host, 0);
> +		mmc_omap_set_power(slot, 0, ios->vdd);
>  		break;
>  	case MMC_POWER_UP:
> -		/* Cannot touch dsor yet, just power up MMC */
> -		mmc_omap_power(host, 1);
> -		return;
>  	case MMC_POWER_ON:
> +		mmc_omap_set_power(slot, 1, ios->vdd);
>  		dsor |= 1 << 11;
>  		break;
>  	}
>  

This part breaks the MMC_POWER_UP vs MMC_POWER_ON again.

This is third time I comment on the same issue I believe. Please
do not revert changes made in linux-omap with your patches.

You must power up MMC with MMC_POWER_UP, and then just set the
divisor in MMC_POWER_ON.

Regards,

Tony