From: Tony Lindgren <tony@atomide.com>
To: Dirk Behme <dirk.behme@googlemail.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH 1/1] ARM: OMAP: Fix musb_core parameter passing to cppi start
Date: Tue, 9 Oct 2007 15:25:56 -0700 [thread overview]
Message-ID: <20071009222556.GH4151@atomide.com> (raw)
In-Reply-To: <470A7862.4060802@googlemail.com>
* Dirk Behme <dirk.behme@googlemail.com> [071008 11:36]:
>
> cppi_controller_start() expects a struct dma_controller as parameter
> and not dma_controller private_data. Current implementation crashes
> with e.g.
>
> Internal error: Oops: 805 [#1]
> Modules linked in:
> CPU: 0 Not tainted (2.6.23-rc4-davinci1 #2)
> PC is at cppi_controller_start+0x18/0x140
> LR is at musb_probe+0x1f4/0x824
>
> Fix this. Initial proposal for fix by David Brownell. Thanks!
>
> Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
>
> Index: linux-osk/drivers/usb/musb/musb_core.c
> ===================================================================
> --- linux-osk.orig/drivers/usb/musb/musb_core.c
> +++ linux-osk/drivers/usb/musb/musb_core.c
> @@ -1980,7 +1980,7 @@ musb_init_controller(struct device *dev,
> c = dma_controller_create(musb, musb->mregs);
> musb->dma_controller = c;
> if (c)
> - (void) c->start(c->private_data);
> + (void) c->start(c);
> }
> #endif
> /* ideally this would be abstracted in platform setup */
>
Pushing today.
Tony
prev parent reply other threads:[~2007-10-09 22:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 18:35 [PATCH 1/1] ARM: OMAP: Fix musb_core parameter passing to cppi start Dirk Behme
2007-10-09 22:25 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071009222556.GH4151@atomide.com \
--to=tony@atomide.com \
--cc=dirk.behme@googlemail.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox