From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 1/1] ARM: OMAP: Fix musb_core parameter passing to cppi
	start
Date: Tue, 9 Oct 2007 15:25:56 -0700
Message-ID: <20071009222556.GH4151@atomide.com>
References: <470A7862.4060802@googlemail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-omap-open-source-bounces@linux.omap.com>
Content-Disposition: inline
In-Reply-To: <470A7862.4060802@googlemail.com>
List-Unsubscribe: <http://linux.omap.com/mailman/listinfo/linux-omap-open-source>,
	<mailto:linux-omap-open-source-request@linux.omap.com?subject=unsubscribe>
List-Archive: <http://linux.omap.com/pipermail/linux-omap-open-source>
List-Post: <mailto:linux-omap-open-source@linux.omap.com>
List-Help: <mailto:linux-omap-open-source-request@linux.omap.com?subject=help>
List-Subscribe: <http://linux.omap.com/mailman/listinfo/linux-omap-open-source>,
	<mailto:linux-omap-open-source-request@linux.omap.com?subject=subscribe>
Sender: linux-omap-open-source-bounces@linux.omap.com
Errors-To: linux-omap-open-source-bounces@linux.omap.com
To: Dirk Behme <dirk.behme@googlemail.com>
Cc: linux-omap-open-source@linux.omap.com
List-Id: linux-omap@vger.kernel.org

* Dirk Behme <dirk.behme@googlemail.com> [071008 11:36]:
>
> cppi_controller_start() expects a struct dma_controller as parameter
> and not dma_controller private_data. Current implementation crashes
> with e.g.
>
> Internal error: Oops: 805 [#1]
> Modules linked in:
> CPU: 0    Not tainted  (2.6.23-rc4-davinci1 #2)
> PC is at cppi_controller_start+0x18/0x140
> LR is at musb_probe+0x1f4/0x824
>
> Fix this. Initial proposal for fix by David Brownell. Thanks!
>
> Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
>

> Index: linux-osk/drivers/usb/musb/musb_core.c
> ===================================================================
> --- linux-osk.orig/drivers/usb/musb/musb_core.c
> +++ linux-osk/drivers/usb/musb/musb_core.c
> @@ -1980,7 +1980,7 @@ musb_init_controller(struct device *dev,
>  		c = dma_controller_create(musb, musb->mregs);
>  		musb->dma_controller = c;
>  		if (c)
> -			(void) c->start(c->private_data);
> +			(void) c->start(c);
>  	}
>  #endif
>  	/* ideally this would be abstracted in platform setup */
> 

Pushing today.

Tony