Re: [patch 2.6.23-omap] misc musb tweaks

David Brownell
2007-10-15T01:10:34Z

On Sunday 14 October 2007, Tony Lindgren wrote:
> I guess we should still at least clean up the CONFIG_USB_INVENTRA_DMA
> sections in the common DMA code before submitting to linux-usb-devel.

That's ugly as all get-out, but not what I'd call a blocking issue.

It *should* be essentially an overhaul to the guts of the DMA glue:
there are {RX,TX}_{submit,complete}_{gadget,host} paths, which should
get unified, then seriously retested on several platforms. That's
not straightforward... and there's no reason not to do that *AFTER*
the code goes upstream.

Similarly with the Blackfin (525?) support: that can be done after
a upstream merge, too.

> What else should we still fix before submitting to linux-usb-devel?

I don't see much of a reason why it shouldn't go upstream "now"...

What we need is someone to create the patches. When I asked a while
back, nobody really objected to "one huge patch" ... though I think
breaking it down into

(a) drivers/usb/musb/*.[hc]
(b) the various platform hooks, in arch/ and include/asm-*/*
(c) kbuild stuff (Kconfig and Makefile updates)

would be best. That is, no need to split out the gadget side
from the host side, or TUSB6010 from OMAP2430 from DaVinci, etc.
(It'd also be good to have a MAINTAINERS entry...)

If someone did that part, and made sure the TUSB6010 stuff would
build on some non-OMAP hardware (without DMA), I could sanity
check it and sign off before sending it upstream. Dunno if it'd
make 2.6.24, but I'd not rule it out.

- Dave