From: Tony Lindgren <tony@atomide.com>
To: Drew Moseley <dmoseley@mvista.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: Need to call kgdb8250_add_platform_port in omap_serial_init()?
Date: Fri, 12 Oct 2007 13:31:08 -0700 [thread overview]
Message-ID: <20071012203107.GJ7979@atomide.com> (raw)
In-Reply-To: <470E63B4.40103@mvista.com>
Hi,
* Drew Moseley <dmoseley@mvista.com> [071011 10:57]:
>
> The patch below calls kgdb8250_add_platform_port() from omap_serial_init().
> This is copied from mach-omap/serial.c. Without this patch kgdbwait
> will fail.
>
> Comments?
Makes sense, but I can't find any references in linux-omap for
kgdb8250_add_platform_port... I guess that's in some other tree?
Regards,
Tony
> Index: linux/arch/arm/mach-omap2/serial.c
> ===================================================================
> --- linux.orig/arch/arm/mach-omap2/serial.c
> +++ linux/arch/arm/mach-omap2/serial.c
> @@ -162,6 +162,9 @@ void __init omap_serial_init()
> }
>
> omap_serial_reset(p);
> +#ifdef CONFIG_KGDB_8250
> + kgdb8250_add_platform_port(i, &serial_platform_data[i]);
> +#endif
> }
> }
>
>
> --
> mailto:dmoseley@mvista.com
> _______________________________________________
> Linux-omap-open-source mailing list
> Linux-omap-open-source@linux.omap.com
> http://linux.omap.com/mailman/listinfo/linux-omap-open-source
next prev parent reply other threads:[~2007-10-12 20:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 17:56 Need to call kgdb8250_add_platform_port in omap_serial_init()? Drew Moseley
2007-10-12 20:31 ` Tony Lindgren [this message]
2007-10-12 20:58 ` Drew Moseley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071012203107.GJ7979@atomide.com \
--to=tony@atomide.com \
--cc=dmoseley@mvista.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox