Need to call kgdb8250_add_platform_port in omap_serial_init()?

Need to call kgdb8250_add_platform_port in omap_serial_init()?

[Drew Moseley]

The patch below calls kgdb8250_add_platform_port() from omap_serial_init().
This is copied from mach-omap/serial.c.  Without this patch kgdbwait
will fail.

Comments?

Drew



Index: linux/arch/arm/mach-omap2/serial.c
===================================================================
--- linux.orig/arch/arm/mach-omap2/serial.c
+++ linux/arch/arm/mach-omap2/serial.c
@@ -162,6 +162,9 @@ void __init omap_serial_init()
 		}

 		omap_serial_reset(p);
+#ifdef CONFIG_KGDB_8250
+		kgdb8250_add_platform_port(i, &serial_platform_data[i]);
+#endif
 	}
 }


-- 
mailto:dmoseley@mvista.com

Re: Need to call kgdb8250_add_platform_port in omap_serial_init()?

[Tony Lindgren]

Hi,

* Drew Moseley <dmoseley@mvista.com> [071011 10:57]:
> 
> The patch below calls kgdb8250_add_platform_port() from omap_serial_init().
> This is copied from mach-omap/serial.c.  Without this patch kgdbwait
> will fail.
> 
> Comments?

Makes sense, but I can't find any references in linux-omap for
kgdb8250_add_platform_port... I guess that's in some other tree?

Regards,

Tony

> Index: linux/arch/arm/mach-omap2/serial.c
> ===================================================================
> --- linux.orig/arch/arm/mach-omap2/serial.c
> +++ linux/arch/arm/mach-omap2/serial.c
> @@ -162,6 +162,9 @@ void __init omap_serial_init()
>  		}
> 
>  		omap_serial_reset(p);
> +#ifdef CONFIG_KGDB_8250
> +		kgdb8250_add_platform_port(i, &serial_platform_data[i]);
> +#endif
>  	}
>  }
> 
> 
> -- 
> mailto:dmoseley@mvista.com
> _______________________________________________
> Linux-omap-open-source mailing list
> Linux-omap-open-source@linux.omap.com
> http://linux.omap.com/mailman/listinfo/linux-omap-open-source

Re: Need to call kgdb8250_add_platform_port in omap_serial_init()?

[Drew Moseley]

Tony Lindgren wrote:
> Hi,
> 
> * Drew Moseley <dmoseley@mvista.com> [071011 10:57]:
>> The patch below calls kgdb8250_add_platform_port() from omap_serial_init().
>> This is copied from mach-omap/serial.c.  Without this patch kgdbwait
>> will fail.
>>
>> Comments?
> 
> Makes sense, but I can't find any references in linux-omap for
> kgdb8250_add_platform_port... I guess that's in some other tree?
> 
> Regards,
> 
> Tony
> 

Indeed.  Sorry about that.  Resubmitted to the kgdb bugreport list.

Drew