From: David Brownell <david-b@pacbell.net>
To: kmpark@infradead.org
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] ARM: OMAP: OMAP2 USB DMA support
Date: Sun, 14 Oct 2007 20:28:14 -0700 [thread overview]
Message-ID: <200710142028.14685.david-b@pacbell.net> (raw)
In-Reply-To: <003401c80ed3$4647fb70$e1ac580a@swcenter.sec.samsung.co.kr>
On Sunday 14 October 2007, Kyungmin Park wrote:
> Hi David Brownell,
>
> Are there any comments?
Didn't know I was expected to comment. :)
I didn't test this myself, so I can't comment on those issues.
And I don't have time to trace the details of the DMA changes
either... it looks plausible though.
Except for this bit at the end:
> @@ -2555,7 +2580,7 @@ omap_ep_setup(char *name, u8 addr, u8 type,
> * (for more reliable behavior)
> */
> if ((!use_dma && (addr & USB_DIR_IN))
> - || machine_is_omap_apollon()
> + || (!use_dma && machine_is_omap_apollon())
> || cpu_is_omap15xx())
> dbuf = 0;
Having board-specific logic for that seems clearly wrong.
(And I never much liked that original bit either...)
- Dave
_______________________________________________
Linux-omap-open-source mailing list
Linux-omap-open-source@linux.omap.com
http://linux.omap.com/mailman/listinfo/linux-omap-open-source
next prev parent reply other threads:[~2007-10-15 3:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-10 3:34 [PATCH] ARM: OMAP: OMAP2 USB DMA support Kyungmin Park
2007-10-15 2:29 ` Kyungmin Park
2007-10-15 3:28 ` David Brownell [this message]
2007-10-31 11:13 ` Tony Lindgren
2007-11-05 1:02 ` Kyungmin Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710142028.14685.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=kmpark@infradead.org \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox