public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@mvista.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] ARM: OMAP: fix default sys_ck.rate for boot-time DPLL detection
Date: Sun, 21 Oct 2007 17:11:53 -0700	[thread overview]
Message-ID: <20071022001153.GG6984@atomide.com> (raw)
In-Reply-To: <20071019211415.183990583@mvista.com>

* Kevin Hilman <khilman@mvista.com> [071019 14:16]:
> In the clock init code, the DPLL value set by the bootloader is
> queried, but always turns zero due it's parent clock (sys_ck) having
> no default rate.  This results in the improper setting of the default
> PRCM rate-table entry and any queries of virt_prcm_set rate to return 0.
> 
> Following the example of the TI kernel, set the default sys_ck rate to
> 13MHz.  Could then be overridden in board setup code.
> 
> Signed-off-by: Kevin Hilman <khilman@mvista.com>
> 
> ---
>  arch/arm/mach-omap2/clock24xx.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: dev/arch/arm/mach-omap2/clock24xx.h
> ===================================================================
> --- dev.orig/arch/arm/mach-omap2/clock24xx.h
> +++ dev/arch/arm/mach-omap2/clock24xx.h
> @@ -581,6 +581,7 @@ static struct clk osc_ck = {		/* (*12, *
>  /* With out modem likely 12MHz, with modem likely 13MHz */
>  static struct clk sys_ck = {		/* (*12, *13, 19.2, 26, 38.4)MHz */
>  	.name		= "sys_ck",		/* ~ ref_clk also */
> +	.rate           = 13000000,
>  	.parent		= &osc_ck,
>  	.flags		= CLOCK_IN_OMAP242X | CLOCK_IN_OMAP243X |
>  				ALWAYS_ENABLED | RATE_PROPAGATES,

Pushing today.

Tony

  reply	other threads:[~2007-10-22  0:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-19 21:14 [PATCH] ARM: OMAP: fix default sys_ck.rate for boot-time DPLL detection Kevin Hilman
2007-10-22  0:11 ` Tony Lindgren [this message]
2007-10-22  7:24 ` Igor Stoppa
2007-10-22 12:37   ` [PATCH] ARM: OMAP: fix default sys_ck.rate for boot-time DPLLdetection Woodruff, Richard
2007-10-22 16:52     ` Kevin Hilman
2007-10-22 21:46       ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071022001153.GG6984@atomide.com \
    --to=tony@atomide.com \
    --cc=khilman@mvista.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox