From: Greg KH <gregkh@suse.de>
To: Medve Emilian-EMMEDVE1 <Emilian.Medve@freescale.com>
Cc: mochel@osdl.org, linux-kernel@vger.kernel.org, hjlipp@web.de,
tilman@imap.cc, gigaset307x-common@lists.sourceforge.net,
kkeil@suse.de, isdn4linux@listserv.isdn4linux.de, mac@melware.de,
linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH resend] Make the dev_*() family of macros in device.hcomplete
Date: Tue, 30 Oct 2007 08:40:08 -0700 [thread overview]
Message-ID: <20071030154008.GA22809@suse.de> (raw)
In-Reply-To: <598D5675D34BE349929AF5EDE9B03E27016E5FCB@az33exm24.fsl.freescale.net>
On Tue, Oct 30, 2007 at 05:11:24AM -0700, Medve Emilian-EMMEDVE1 wrote:
> Hi Greg K-H,
>
>
> > > +#define dev_info(dev, format, arg...) \
> > > + dev_printk(KERN_INFO, dev, format, ## arg)
> > > +
> > > #ifdef DEBUG
> > > #define dev_dbg(dev, format, arg...) \
> > > - dev_printk(KERN_DEBUG , dev , format , ## arg)
> > > + dev_printk(KERN_DEBUG, dev, format, ## arg)
> >
> > Those extra spaces are there for a good reason, older versions of gcc
> > are broken without it. So please, put them all back...
>
> You mean I should add spaces before commas only where they were
> initially or to all new code and/or macros?
Put it back where it was, and do the same for all other macros.
> I've observed other kernel code and more often there are no spaces
> before commas. I'm asking because the CodingStyle document is not very
> explicit about this rule.
This is a gcc rule, for variable length macros, not a CodingStyle
guideline. It just will not work without it :)
thanks,
greg k-h
next prev parent reply other threads:[~2007-10-30 15:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1193697795-7823-1-git-send-email-Emilian.Medve@Freescale.com>
2007-10-29 23:08 ` [PATCH resend] Make the dev_*() family of macros in device.h complete Tilman Schmidt
2007-10-30 0:00 ` Greg KH
2007-10-30 12:11 ` [PATCH resend] Make the dev_*() family of macros in device.hcomplete Medve Emilian-EMMEDVE1
2007-10-30 15:29 ` Randy Dunlap
2007-10-30 15:40 ` Greg KH [this message]
2007-11-01 23:57 ` Andrew Morton
2007-11-02 11:59 ` Medve Emilian-EMMEDVE1
2007-11-02 15:35 ` Greg KH
2007-11-02 15:35 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071030154008.GA22809@suse.de \
--to=gregkh@suse.de \
--cc=Emilian.Medve@freescale.com \
--cc=gigaset307x-common@lists.sourceforge.net \
--cc=hjlipp@web.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap-open-source@linux.omap.com \
--cc=mac@melware.de \
--cc=mochel@osdl.org \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox