Re: [PATCH] ARM: OMAP: OMAP2 USB DMA support

[Tony Lindgren <tony@atomide.com>]

Hi,

* David Brownell <david-b@pacbell.net> [071014 20:29]:
> On Sunday 14 October 2007, Kyungmin Park wrote:
> > Hi David Brownell,
> > 
> > Are there any comments?
> 
> Didn't know I was expected to comment.  :)
> 
> I didn't test this myself, so I can't comment on those issues.
> And I don't have time to trace the details of the DMA changes
> either... it looks plausible though.
> 
> Except for this bit at the end:
> 
> > @@ -2555,7 +2580,7 @@ omap_ep_setup(char *name, u8 addr, u8 type,
> >                  * (for more reliable behavior)
> >                  */
> >                 if ((!use_dma && (addr & USB_DIR_IN))
> > -                               || machine_is_omap_apollon()
> > +                               || (!use_dma && machine_is_omap_apollon())
> >                                 || cpu_is_omap15xx())
> >                         dbuf = 0;
> 
> Having board-specific logic for that seems clearly wrong.
> (And I never much liked that original bit either...)

Kyungmin, could you please move the dbuf value into platform data
and have it set in omap_otg_init() in plat-omap/usb.c so Dave
will be happy and we can get your patch integrated into Linus'
tree also?

Regards,

Tony