From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] include/asm-arm/arch-omap/omap24xx.h Date: Wed, 31 Oct 2007 08:22:30 -0700 Message-ID: <20071031152230.GP32547@atomide.com> References: <471F868A.3060106@googlemail.com> <20071025053143.222542615@pwsan.com> <4720B62A.1010406@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: Paul Walmsley Cc: linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org * Paul Walmsley [071025 09:01]: > Hello Dirk, > > On Thu, 25 Oct 2007, Dirk Behme wrote: > >> Mmh, I like to fix it in include/asm-arm/arch-omap/omap24xx.h, so I prefer >> [1]. >> >> With [1] we >> >> - fix it where it was introduced >> - have an additional #ifdef only in a header file instead of >> plat-omap/devices.c, which is IMHO better >> - fix it for everybody now and in the future who directly or indirectly >> includes omap24xx.h. > > Hopefully this is just a workaround until we can get rid of these > conditional defines for multiboot kernels. Generally speaking, would you > propose doing the same thing for the other conditional defines in > include/asm-arm/arch-omap/omap24xx.h, such as OMAP2_32KSYNCT_BASE, > OMAP2_SDRC_BASE, etc.? Sounds like the real fix is to set these addresses in the init code somewhere based on the omap type. Tony