* Tony Lindgren [071031 08:22]: > * Paul Walmsley [071025 09:01]: > > > Hello Dirk, > > > > On Thu, 25 Oct 2007, Dirk Behme wrote: > > > >> Mmh, I like to fix it in include/asm-arm/arch-omap/omap24xx.h, so I prefer > >> [1]. > >> > >> With [1] we > >> > >> - fix it where it was introduced > >> - have an additional #ifdef only in a header file instead of > >> plat-omap/devices.c, which is IMHO better > >> - fix it for everybody now and in the future who directly or indirectly > >> includes omap24xx.h. > > > > Hopefully this is just a workaround until we can get rid of these > > conditional defines for multiboot kernels. Generally speaking, would you > > propose doing the same thing for the other conditional defines in > > include/asm-arm/arch-omap/omap24xx.h, such as OMAP2_32KSYNCT_BASE, > > OMAP2_SDRC_BASE, etc.? > > Sounds like the real fix is to set these addresses in the init code > somewhere based on the omap type. I'll push a temporary fix based on Luis' patch, see below. Tony