* [PATCH] ARM: OMAP: compile-fixes for PM debug
@ 2007-10-30 11:40 Kevin Hilman
2007-10-30 12:14 ` Felipe Balbi
0 siblings, 1 reply; 5+ messages in thread
From: Kevin Hilman @ 2007-10-30 11:40 UTC (permalink / raw)
To: linux-omap-open-source
Fix compile problems in omap2_pm_debug()
Signed-off-by: Kevin Hilman <khilman@mvista.com>
---
arch/arm/mach-omap2/pm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: dev/arch/arm/mach-omap2/pm.c
===================================================================
--- dev.orig/arch/arm/mach-omap2/pm.c
+++ dev/arch/arm/mach-omap2/pm.c
@@ -240,15 +240,15 @@ static void omap2_pm_dump(int mode, int
#endif
#if 0
DUMP_CM_MOD_REG(CORE_MOD, CM_FCLKEN1);
- DUMP_CM_MOD_REG(CORE_MOD, CM_FCLKEN2);
+ DUMP_CM_MOD_REG(CORE_MOD, OMAP24XX_CM_FCLKEN2);
DUMP_CM_MOD_REG(WKUP_MOD, CM_FCLKEN);
DUMP_CM_MOD_REG(CORE_MOD, CM_ICLKEN1);
DUMP_CM_MOD_REG(CORE_MOD, CM_ICLKEN2);
DUMP_CM_MOD_REG(WKUP_MOD, CM_ICLKEN);
- DUMP_CM_MOD_REG(PLL_MOD, CM_CLKEN_PLL);
+ DUMP_CM_MOD_REG(PLL_MOD, CM_CLKEN);
DUMP_PRM_REG(OMAP24XX_PRCM_CLKEMUL_CTRL);
DUMP_CM_MOD_REG(PLL_MOD, CM_AUTOIDLE);
- DUMP_PRM_MOD_REG(CORE_REG, PM_PWSTST);
+ DUMP_PRM_MOD_REG(CORE_MOD, PM_PWSTST);
DUMP_PRM_REG(OMAP24XX_PRCM_CLKSRC_CTRL);
#endif
#if 0
--
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: OMAP: compile-fixes for PM debug
2007-10-30 11:40 [PATCH] ARM: OMAP: compile-fixes for PM debug Kevin Hilman
@ 2007-10-30 12:14 ` Felipe Balbi
2007-10-30 13:18 ` Kevin Hilman
0 siblings, 1 reply; 5+ messages in thread
From: Felipe Balbi @ 2007-10-30 12:14 UTC (permalink / raw)
To: Kevin Hilman; +Cc: linux-omap-open-source
Hi,
On 10/30/07, Kevin Hilman <khilman@mvista.com> wrote:
> Fix compile problems in omap2_pm_debug()
>
> Signed-off-by: Kevin Hilman <khilman@mvista.com>
> ---
> arch/arm/mach-omap2/pm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Index: dev/arch/arm/mach-omap2/pm.c
> ===================================================================
> --- dev.orig/arch/arm/mach-omap2/pm.c
> +++ dev/arch/arm/mach-omap2/pm.c
> @@ -240,15 +240,15 @@ static void omap2_pm_dump(int mode, int
> #endif
> #if 0
> DUMP_CM_MOD_REG(CORE_MOD, CM_FCLKEN1);
> - DUMP_CM_MOD_REG(CORE_MOD, CM_FCLKEN2);
> + DUMP_CM_MOD_REG(CORE_MOD, OMAP24XX_CM_FCLKEN2);
Are you sure this is needed? This code is commented.
> DUMP_CM_MOD_REG(WKUP_MOD, CM_FCLKEN);
> DUMP_CM_MOD_REG(CORE_MOD, CM_ICLKEN1);
> DUMP_CM_MOD_REG(CORE_MOD, CM_ICLKEN2);
> DUMP_CM_MOD_REG(WKUP_MOD, CM_ICLKEN);
> - DUMP_CM_MOD_REG(PLL_MOD, CM_CLKEN_PLL);
> + DUMP_CM_MOD_REG(PLL_MOD, CM_CLKEN);
> DUMP_PRM_REG(OMAP24XX_PRCM_CLKEMUL_CTRL);
> DUMP_CM_MOD_REG(PLL_MOD, CM_AUTOIDLE);
> - DUMP_PRM_MOD_REG(CORE_REG, PM_PWSTST);
> + DUMP_PRM_MOD_REG(CORE_MOD, PM_PWSTST);
> DUMP_PRM_REG(OMAP24XX_PRCM_CLKSRC_CTRL);
> #endif
> #if 0
> --
> _______________________________________________
> Linux-omap-open-source mailing list
> Linux-omap-open-source@linux.omap.com
> http://linux.omap.com/mailman/listinfo/linux-omap-open-source
>
--
Best Regards,
Felipe Balbi
felipebalbi@users.sourceforge.net
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: OMAP: compile-fixes for PM debug
2007-10-30 12:14 ` Felipe Balbi
@ 2007-10-30 13:18 ` Kevin Hilman
2007-10-30 13:53 ` Felipe Balbi
0 siblings, 1 reply; 5+ messages in thread
From: Kevin Hilman @ 2007-10-30 13:18 UTC (permalink / raw)
To: Felipe Balbi; +Cc: linux-omap-open-source
Felipe Balbi wrote:
> Hi,
>
> On 10/30/07, Kevin Hilman <khilman@mvista.com> wrote:
>> Fix compile problems in omap2_pm_debug()
>>
>> Signed-off-by: Kevin Hilman <khilman@mvista.com>
>> ---
>> arch/arm/mach-omap2/pm.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> Index: dev/arch/arm/mach-omap2/pm.c
>> ===================================================================
>> --- dev.orig/arch/arm/mach-omap2/pm.c
>> +++ dev/arch/arm/mach-omap2/pm.c
>> @@ -240,15 +240,15 @@ static void omap2_pm_dump(int mode, int
>> #endif
>> #if 0
>> DUMP_CM_MOD_REG(CORE_MOD, CM_FCLKEN1);
>> - DUMP_CM_MOD_REG(CORE_MOD, CM_FCLKEN2);
>> + DUMP_CM_MOD_REG(CORE_MOD, OMAP24XX_CM_FCLKEN2);
>
> Are you sure this is needed? This code is commented.
>
It is needed when the code is uncommented, which is used for debugging
suspend/resume and sleep-when-idle.
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: OMAP: compile-fixes for PM debug
2007-10-30 13:18 ` Kevin Hilman
@ 2007-10-30 13:53 ` Felipe Balbi
2007-11-01 8:53 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Felipe Balbi @ 2007-10-30 13:53 UTC (permalink / raw)
To: Kevin Hilman; +Cc: linux-omap-open-source
On 10/30/07, Kevin Hilman <khilman@mvista.com> wrote:
<snip>
> It is needed when the code is uncommented, which is used for debugging
> suspend/resume and sleep-when-idle.
ok... ack
>
> Kevin
>
--
Best Regards,
Felipe Balbi
felipebalbi@users.sourceforge.net
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: OMAP: compile-fixes for PM debug
2007-10-30 13:53 ` Felipe Balbi
@ 2007-11-01 8:53 ` Tony Lindgren
0 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2007-11-01 8:53 UTC (permalink / raw)
To: Felipe Balbi; +Cc: linux-omap-open-source
* Felipe Balbi <felipebalbi@users.sourceforge.net> [071030 06:57]:
> On 10/30/07, Kevin Hilman <khilman@mvista.com> wrote:
>
> <snip>
>
> > It is needed when the code is uncommented, which is used for debugging
> > suspend/resume and sleep-when-idle.
>
> ok... ack
Pushing Kevin's patch today.
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-11-01 8:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-30 11:40 [PATCH] ARM: OMAP: compile-fixes for PM debug Kevin Hilman
2007-10-30 12:14 ` Felipe Balbi
2007-10-30 13:18 ` Kevin Hilman
2007-10-30 13:53 ` Felipe Balbi
2007-11-01 8:53 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox