From: David Brownell <david-b@pacbell.net>
To: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] fix NULL pointer with MUSB and DMA on ISO ep
Date: Fri, 2 Nov 2007 09:36:33 -0700 [thread overview]
Message-ID: <200711020936.33644.david-b@pacbell.net> (raw)
In-Reply-To: <200711011540.49801.hyau@mvista.com>
On Thursday 01 November 2007, Hunyue Yau wrote:
> Hi,
>
> The MUSB driver fails to pass a proper buffer pointer to
> musb_write_fifo if DMA is enabled and it is an ISO endpoint.
> This removes the check that was preventing a proper buffer
> pointer from being passed.
>
> Tested with a bluetooth headset and USB bluetooth dongle
> using SCO audio on the 2430SDP.
>
> -- Hunyue
> ---------------------------------------------------------------------------------
> Description:
> For the case of an isochonous endpoint, musb_write_fifo may be
> called with a NULL buffer from musb_host_tx if DMA is enabled.
> Remove DMA check and always supply a valid buffer as long as
> the URB contains a valid buffer.
>
> Signed-off-by: Hunyue Yau <hyau@mvista.com>
>
> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
> index e488ac7..a7fe072 100644
> --- a/drivers/usb/musb/musb_host.c
> +++ b/drivers/usb/musb/musb_host.c
> @@ -1258,7 +1258,7 @@ void musb_host_tx(struct musb *musb, u8 epnum)
> d->actual_length = qh->segsize;
> if (++qh->iso_idx >= urb->number_of_packets) {
> done = true;
> - } else if (!dma) {
> + } else {
... looks right. ACK.
> d++;
> buf = urb->transfer_buffer + d->offset;
> wLength = d->length;
>
> _______________________________________________
> Linux-omap-open-source mailing list
> Linux-omap-open-source@linux.omap.com
> http://linux.omap.com/mailman/listinfo/linux-omap-open-source
>
next prev parent reply other threads:[~2007-11-02 16:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-01 22:40 [PATCH] fix NULL pointer with MUSB and DMA on ISO ep Hunyue Yau
2007-11-02 16:36 ` David Brownell [this message]
2007-11-15 20:51 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711020936.33644.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox