From: Daniel Stone <daniel.stone@nokia.com>
To: ext Girish <girishsg@ti.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATC 2/3] silicon revision check for OMAP2/3
Date: Fri, 2 Nov 2007 17:57:06 +0200 [thread overview]
Message-ID: <20071102155706.GA24982@intune.research.nokia.com> (raw)
In-Reply-To: <00f201c81d5e$c4aaac30$6a8918ac@ent.ti.com>
Hi,
On Fri, Nov 02, 2007 at 08:13:44PM +0530, ext Girish wrote:
> # undef cpu_is_omap3430
> -# define cpu_is_omap3430() is_omap3430()
> +#define cpu_is_omap3430() is_omap3430()
Why the inconsistency?
> +#define is_device_type_test() \
> + (((system_rev & 0x700) >> 8) == DEVICE_TYPE_TEST)
> + [...]
> +#define get_device_type() \
> + ((system_rev & 0x700) >> 8)
Nice work on defining the get_device_type() macro, but why not use it
above, so you have:
#define is_device_type_test() (get_device_type == DEVICE_TYPE_TEST)
Cheers,
Daniel
next prev parent reply other threads:[~2007-11-02 15:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-02 14:43 [PATC 2/3] silicon revision check for OMAP2/3 Girish
2007-11-02 15:57 ` Daniel Stone [this message]
2007-11-05 11:59 ` Girish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071102155706.GA24982@intune.research.nokia.com \
--to=daniel.stone@nokia.com \
--cc=girishsg@ti.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox