Re: [PATCH 1/3] ARM: OMAP: Add helper module for board specific I2C bus registration

[Tony Lindgren <tony@atomide.com>]

* Jarkko Nikula <jarkko.nikula@nokia.com> [071106 02:53]:
> On Tue, 6 Nov 2007 00:26:57 -0800
> "ext David Brownell" <david-b@pacbell.net> wrote:
> 
> > > +/*
> > > + * REVISIT: How many boards really require muxing here? It should
> > > be done
> > > + * by the bootloader 
> > 
> > Erm, not as a rule.  The last policy I recall being discussed
> > was that Linux should not trust the boot loader to have set
> > up pin muxing.  If a product is being developed with a boot
> > loader which does that, fine -- resolve that by configuring
> > the pinmux support out of Linux.  That would be an OPTION.
> > 
> > But in all cases, the Linux code shold include pinmux support.
> > That way drivers etc can be properly debugged without needing
> > to depend on bootloader bugfixes of any type.
> > 
> Ok, now I got the point :-)
> 
> So here is the latest version:
> 
> static void omap_i2c_mux_pins(int bus_id)
> {
> 	/* TODO: Muxing for OMAP3 */
> 	switch (bus_id) {
> 	case 1:
> 		if (cpu_class_is_omap1()) {
> 			omap_cfg_reg(I2C_SCL);
> 			omap_cfg_reg(I2C_SDA);
> 		} else if (cpu_class_is_omap2()) {
> 			omap_cfg_reg(M19_24XX_I2C1_SCL);
> 			omap_cfg_reg(L15_24XX_I2C1_SDA);
> 		}
> 		break;
> 	case 2:
> 		if (cpu_is_omap24xx()) {
> 			omap_cfg_reg(J15_24XX_I2C2_SCL);
> 			omap_cfg_reg(H19_24XX_I2C2_SDA);
> 		}
> 		break;
> 	}
> }
> 
> I think no need to cover CONFIG_OMAP_MUX here since omap_cfg_reg has
> null implementation if it's not enabled?

Yeah it's null if not enabled.

Tony