From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] include/asm-arm/arch-omap/omap24xx.h
Date: Tue, 6 Nov 2007 04:58:36 -0800 [thread overview]
Message-ID: <20071106125835.GH19275@atomide.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0711060318490.25907@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [071106 02:23]:
> Hello Dirk,
>
> On Mon, 5 Nov 2007, Dirk Behme wrote:
>
> > Until we have real fix like above: Instead of now trying to cover all
> > situations where OMAP2_CTRL_BASE is undefined or redefinded (maybe there are
> > some more?), I wonder why not simply make it self-dependent?
> >
> > #if !defined(OMAP2_CTRL_BASE)
> > /* FIXME: These will go away soon */
> > #define OMAP2_CTRL_BASE L4_24XX_BASE
> > #endif
>
> I don't think that will work. Consider the case of a file that
> includes both omap24xx.h and omap34xx.h during a 3430 build. When
> omap24xx.h is processed, OMAP2_CTRL_BASE will be defined by the above
> code; then omap34xx.h will redefine it, causing the same warning.
Yup, pushed that fix.
Tony
next prev parent reply other threads:[~2007-11-06 12:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 16:58 [PATCH] include/asm-arm/arch-omap/omap24xx.h Luís Cargnini
2007-10-24 17:53 ` Dirk Behme
2007-10-25 5:31 ` Paul Walmsley
2007-10-25 5:31 ` fix undeclared OMAP2_CTRL_BASE for OMAP MMC driver in OMAP1 compiles Paul Walmsley
2007-10-25 5:54 ` [PATCH] include/asm-arm/arch-omap/omap24xx.h Luís Cargnini
2007-10-25 15:28 ` Dirk Behme
2007-10-25 16:00 ` Paul Walmsley
2007-10-31 15:22 ` Tony Lindgren
2007-11-01 8:29 ` Tony Lindgren
2007-11-05 7:57 ` Paul Walmsley
2007-11-05 19:34 ` Dirk Behme
2007-11-06 10:23 ` Paul Walmsley
2007-11-06 12:58 ` Tony Lindgren [this message]
2007-11-07 4:21 ` Luís Cargnini
-- strict thread matches above, loose matches on Subject: below --
2007-11-07 4:27 [PATCH]include/asm-arm/arch-omap/omap24xx.h Luís Cargnini
2007-11-15 21:24 ` [PATCH]include/asm-arm/arch-omap/omap24xx.h Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071106125835.GH19275@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox