From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] include/asm-arm/arch-omap/omap24xx.h Date: Tue, 6 Nov 2007 04:58:36 -0800 Message-ID: <20071106125835.GH19275@atomide.com> References: <471F868A.3060106@googlemail.com> <20071025053143.222542615@pwsan.com> <4720B62A.1010406@googlemail.com> <20071031152230.GP32547@atomide.com> <20071101082943.GA780@atomide.com> <472F7031.3000308@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: Paul Walmsley Cc: linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org * Paul Walmsley [071106 02:23]: > Hello Dirk, > > On Mon, 5 Nov 2007, Dirk Behme wrote: > > > Until we have real fix like above: Instead of now trying to cover all > > situations where OMAP2_CTRL_BASE is undefined or redefinded (maybe there are > > some more?), I wonder why not simply make it self-dependent? > > > > #if !defined(OMAP2_CTRL_BASE) > > /* FIXME: These will go away soon */ > > #define OMAP2_CTRL_BASE L4_24XX_BASE > > #endif > > I don't think that will work. Consider the case of a file that > includes both omap24xx.h and omap34xx.h during a 3430 build. When > omap24xx.h is processed, OMAP2_CTRL_BASE will be defined by the above > code; then omap34xx.h will redefine it, causing the same warning. Yup, pushed that fix. Tony