From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jarkko.nikula@nokia.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] CBUS: Do not BUG_ON in retu-headset in case of spurious release event
Date: Thu, 15 Nov 2007 13:30:04 -0800 [thread overview]
Message-ID: <20071115213004.GP20686@atomide.com> (raw)
In-Reply-To: <1194961994-12212-1-git-send-email-jarkko.nikula@nokia.com>
* Jarkko Nikula <jarkko.nikula@nokia.com> [071113 05:53]:
> There is a small chance that retu_headset_detect_timer can run twice
> and pressed flag being zero in second run. Do nothing in that case instead
> of throwing BUG_ON.
>
> Double run can happen under very busy system assuming following scenario
>
> 1. Hook interrupt (run in softirq context, pressed flag = 1)
> 2. First retu_headset_enable_timer call
> 3. Busy system, retu raises an interrupt but cannot run hook interrupt for
> 300-350 ms
> 4. Second hook interrupt
> 5. First retu_headset_detect_timer call (pressed flag = 0)
> 6. Second retu_headset_enable_timer
> 7. Second retu_headset_detect_timer
> -> pressed flag == 0 => BUG_ON
>
> Patch also removes two debug messages since they are not needed very much
> and removal cleans up code a bit.
Pushing today.
Tony
prev parent reply other threads:[~2007-11-15 21:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 13:53 [PATCH] CBUS: Do not BUG_ON in retu-headset in case of spurious release event Jarkko Nikula
2007-11-15 21:30 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071115213004.GP20686@atomide.com \
--to=tony@atomide.com \
--cc=jarkko.nikula@nokia.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox