Re: [PATCH RESEND 0/4] Runtime constants: define (some) OMAP address bases at runtime rather than compile time for multiboot

[Jarkko Nikula <jarkko.nikula@nokia.com>]

On Wed, 21 Nov 2007 00:13:17 -0700 (MST)
"ext Paul Walmsley" <paul@pwsan.com> wrote:

> > How about calling omap2_set_globals_242x() from
> > arch/arm/mach-omap2/io.c: omap2_map_common_io() in order to avoid
> > modifications to n board files?
> 
> We could do that, but we'd still need to modify the board files to
> pass in the OMAP type to omap2_map_common_io().  
> 
> In an ideal world, we could just use omap2_check_revision() to
> determine the CPU type at runtime, but the TAP base address is not
> the same across all OMAPs, and must therefore itself be modified for
> multiboot :-(
> 
Ah, yes, I see. Chicken and egg problem.

void __init omap2_map_common_io(void)
{
...
	/* revision? TAP base ?*/
	omap2_check_revision();
...

I think at this point it is better to modify n board files, as your set
is doing, instead of modifying omap2_map_common_io() API? At least both
add & possible clean-up patches will be just one liners only.


	Jarkko