From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] Remove unused and broken core_l3_ck clk_get from board-3430sdp.c
Date: Fri, 23 Nov 2007 12:29:08 -0800 [thread overview]
Message-ID: <20071123202907.GD559@atomide.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0711161713550.13378@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [071116 16:15]:
>
> board-3430sdp.c tries to clk_get core_l3_ck. This clock doesn't exist
> any longer in the current clock34xx.h, so it fails. The code then tries
> to fetch the clock's rate, which is also not currently used. This is
> dead code, so remove it.
>
> Tested on 3430SDP ES1.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
>
> ---
> arch/arm/mach-omap2/board-3430sdp.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> Index: linux-omap/arch/arm/mach-omap2/board-3430sdp.c
> ===================================================================
> --- linux-omap.orig/arch/arm/mach-omap2/board-3430sdp.c 2007-11-16 16:36:01.000000000 -0700
> +++ linux-omap/arch/arm/mach-omap2/board-3430sdp.c 2007-11-16 16:37:42.000000000 -0700
> @@ -264,16 +264,8 @@
> {
> int eth_cs;
> unsigned long cs_mem_base;
> - unsigned int rate;
> - struct clk *l3ck;
>
> - eth_cs = SDP3430_SMC91X_CS;
> -
> - l3ck = clk_get(NULL, "core_l3_ck");
> - if (IS_ERR(l3ck))
> - rate = 100000000;
> - else
> - rate = clk_get_rate(l3ck);
> + eth_cs = SDP3430_SMC91X_CS;
>
> if (gpmc_cs_request(eth_cs, SZ_16M, &cs_mem_base) < 0) {
> printk(KERN_ERR "Failed to request GPMC mem for smc91x\n");
Pushing today.
Tony
prev parent reply other threads:[~2007-11-23 20:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-17 0:14 [PATCH] Remove unused and broken core_l3_ck clk_get from board-3430sdp.c Paul Walmsley
2007-11-23 20:29 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071123202907.GD559@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox