* [PATCH] Remove unused and broken core_l3_ck clk_get from board-3430sdp.c
@ 2007-11-17 0:14 Paul Walmsley
2007-11-23 20:29 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Paul Walmsley @ 2007-11-17 0:14 UTC (permalink / raw)
To: linux-omap-open-source
board-3430sdp.c tries to clk_get core_l3_ck. This clock doesn't exist
any longer in the current clock34xx.h, so it fails. The code then tries
to fetch the clock's rate, which is also not currently used. This is
dead code, so remove it.
Tested on 3430SDP ES1.
Signed-off-by: Paul Walmsley <paul@pwsan.com>
---
arch/arm/mach-omap2/board-3430sdp.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
Index: linux-omap/arch/arm/mach-omap2/board-3430sdp.c
===================================================================
--- linux-omap.orig/arch/arm/mach-omap2/board-3430sdp.c 2007-11-16 16:36:01.000000000 -0700
+++ linux-omap/arch/arm/mach-omap2/board-3430sdp.c 2007-11-16 16:37:42.000000000 -0700
@@ -264,16 +264,8 @@
{
int eth_cs;
unsigned long cs_mem_base;
- unsigned int rate;
- struct clk *l3ck;
- eth_cs = SDP3430_SMC91X_CS;
-
- l3ck = clk_get(NULL, "core_l3_ck");
- if (IS_ERR(l3ck))
- rate = 100000000;
- else
- rate = clk_get_rate(l3ck);
+ eth_cs = SDP3430_SMC91X_CS;
if (gpmc_cs_request(eth_cs, SZ_16M, &cs_mem_base) < 0) {
printk(KERN_ERR "Failed to request GPMC mem for smc91x\n");
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove unused and broken core_l3_ck clk_get from board-3430sdp.c
2007-11-17 0:14 [PATCH] Remove unused and broken core_l3_ck clk_get from board-3430sdp.c Paul Walmsley
@ 2007-11-23 20:29 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2007-11-23 20:29 UTC (permalink / raw)
To: Paul Walmsley; +Cc: linux-omap-open-source
* Paul Walmsley <paul@pwsan.com> [071116 16:15]:
>
> board-3430sdp.c tries to clk_get core_l3_ck. This clock doesn't exist
> any longer in the current clock34xx.h, so it fails. The code then tries
> to fetch the clock's rate, which is also not currently used. This is
> dead code, so remove it.
>
> Tested on 3430SDP ES1.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
>
> ---
> arch/arm/mach-omap2/board-3430sdp.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> Index: linux-omap/arch/arm/mach-omap2/board-3430sdp.c
> ===================================================================
> --- linux-omap.orig/arch/arm/mach-omap2/board-3430sdp.c 2007-11-16 16:36:01.000000000 -0700
> +++ linux-omap/arch/arm/mach-omap2/board-3430sdp.c 2007-11-16 16:37:42.000000000 -0700
> @@ -264,16 +264,8 @@
> {
> int eth_cs;
> unsigned long cs_mem_base;
> - unsigned int rate;
> - struct clk *l3ck;
>
> - eth_cs = SDP3430_SMC91X_CS;
> -
> - l3ck = clk_get(NULL, "core_l3_ck");
> - if (IS_ERR(l3ck))
> - rate = 100000000;
> - else
> - rate = clk_get_rate(l3ck);
> + eth_cs = SDP3430_SMC91X_CS;
>
> if (gpmc_cs_request(eth_cs, SZ_16M, &cs_mem_base) < 0) {
> printk(KERN_ERR "Failed to request GPMC mem for smc91x\n");
Pushing today.
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-23 20:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-17 0:14 [PATCH] Remove unused and broken core_l3_ck clk_get from board-3430sdp.c Paul Walmsley
2007-11-23 20:29 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox