public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: OMAP: Enable OMAP3 SDRC clock on init.
@ 2007-11-20 22:16 Kevin Hilman
  2007-11-20 22:44 ` Kevin Hilman
  0 siblings, 1 reply; 4+ messages in thread
From: Kevin Hilman @ 2007-11-20 22:16 UTC (permalink / raw)
  To: linux-omap; +Cc: linux-omap-open-source

Enable sdrc_ick on init so it doesn't get disabled when
CONFIG_OMAP_RESET_CLOCKS=y

Signed-off-by: Kevin Hilman <khilman@mvista.com>
---
 arch/arm/mach-omap2/clock34xx.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/clock34xx.h b/arch/arm/mach-omap2/clock34xx.h
index b8132a1..a5321bb 100644
--- a/arch/arm/mach-omap2/clock34xx.h
+++ b/arch/arm/mach-omap2/clock34xx.h
@@ -1101,7 +1101,7 @@ static struct clk sdrc_ick = {
 	.parent		= &core_l3_ick,
 	.enable_reg	= OMAP_CM_REGADDR(CORE_MOD, CM_ICLKEN1),
 	.enable_bit	= OMAP3430_EN_SDRC_SHIFT,
-	.flags		= CLOCK_IN_OMAP343X,
+	.flags		= CLOCK_IN_OMAP343X | ENABLE_ON_INIT,
 	.recalc		= &followparent_recalc,
 };
 
-- 
1.5.3.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: OMAP: Enable OMAP3 SDRC clock on init.
  2007-11-20 22:16 [PATCH] ARM: OMAP: Enable OMAP3 SDRC clock on init Kevin Hilman
@ 2007-11-20 22:44 ` Kevin Hilman
  2007-11-20 22:58   ` Kevin Hilman
  0 siblings, 1 reply; 4+ messages in thread
From: Kevin Hilman @ 2007-11-20 22:44 UTC (permalink / raw)
  To: linux-omap; +Cc: linux-omap-open-source


On Tue, 2007-11-20 at 14:16 -0800, Kevin Hilman wrote:
> Enable sdrc_ick on init so it doesn't get disabled when
> CONFIG_OMAP_RESET_CLOCKS=y

FYI... with this patch and the previous UART3 patch, the 'disable unused
clocks' feature is working on 3430SDP

Kevin

> Signed-off-by: Kevin Hilman <khilman@mvista.com>
> ---
>  arch/arm/mach-omap2/clock34xx.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/clock34xx.h b/arch/arm/mach-omap2/clock34xx.h
> index b8132a1..a5321bb 100644
> --- a/arch/arm/mach-omap2/clock34xx.h
> +++ b/arch/arm/mach-omap2/clock34xx.h
> @@ -1101,7 +1101,7 @@ static struct clk sdrc_ick = {
>  	.parent		= &core_l3_ick,
>  	.enable_reg	= OMAP_CM_REGADDR(CORE_MOD, CM_ICLKEN1),
>  	.enable_bit	= OMAP3430_EN_SDRC_SHIFT,
> -	.flags		= CLOCK_IN_OMAP343X,
> +	.flags		= CLOCK_IN_OMAP343X | ENABLE_ON_INIT,
>  	.recalc		= &followparent_recalc,
>  };
>  

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: OMAP: Enable OMAP3 SDRC clock on init.
  2007-11-20 22:44 ` Kevin Hilman
@ 2007-11-20 22:58   ` Kevin Hilman
  2007-11-23 20:34     ` Tony Lindgren
  0 siblings, 1 reply; 4+ messages in thread
From: Kevin Hilman @ 2007-11-20 22:58 UTC (permalink / raw)
  To: linux-omap; +Cc: linux-omap-open-source


On Tue, 2007-11-20 at 14:44 -0800, Kevin Hilman wrote:
> On Tue, 2007-11-20 at 14:16 -0800, Kevin Hilman wrote:
> > Enable sdrc_ick on init so it doesn't get disabled when
> > CONFIG_OMAP_RESET_CLOCKS=y
> 
> FYI... with this patch and the previous UART3 patch, the 'disable unused
> clocks' feature is working on 3430SDP

I forgot to mention that for this to work in 32k-timer mode, the my
32k-timer fixups for OMAP3430[1] are needed.

Kevin

[1]
http://linux.omap.com/pipermail/linux-omap-open-source/2007-November/011958.html
> Kevin
> 
> > Signed-off-by: Kevin Hilman <khilman@mvista.com>
> > ---
> >  arch/arm/mach-omap2/clock34xx.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/clock34xx.h b/arch/arm/mach-omap2/clock34xx.h
> > index b8132a1..a5321bb 100644
> > --- a/arch/arm/mach-omap2/clock34xx.h
> > +++ b/arch/arm/mach-omap2/clock34xx.h
> > @@ -1101,7 +1101,7 @@ static struct clk sdrc_ick = {
> >  	.parent		= &core_l3_ick,
> >  	.enable_reg	= OMAP_CM_REGADDR(CORE_MOD, CM_ICLKEN1),
> >  	.enable_bit	= OMAP3430_EN_SDRC_SHIFT,
> > -	.flags		= CLOCK_IN_OMAP343X,
> > +	.flags		= CLOCK_IN_OMAP343X | ENABLE_ON_INIT,
> >  	.recalc		= &followparent_recalc,
> >  };
> >  
> _______________________________________________
> Linux-omap-open-source mailing list
> Linux-omap-open-source@linux.omap.com
> http://linux.omap.com/mailman/listinfo/linux-omap-open-source

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: OMAP: Enable OMAP3 SDRC clock on init.
  2007-11-20 22:58   ` Kevin Hilman
@ 2007-11-23 20:34     ` Tony Lindgren
  0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2007-11-23 20:34 UTC (permalink / raw)
  To: Kevin Hilman; +Cc: linux-omap, linux-omap-open-source

* Kevin Hilman <khilman@mvista.com> [071120 15:00]:
> 
> On Tue, 2007-11-20 at 14:44 -0800, Kevin Hilman wrote:
> > On Tue, 2007-11-20 at 14:16 -0800, Kevin Hilman wrote:
> > > Enable sdrc_ick on init so it doesn't get disabled when
> > > CONFIG_OMAP_RESET_CLOCKS=y
> > 
> > FYI... with this patch and the previous UART3 patch, the 'disable unused
> > clocks' feature is working on 3430SDP

Nice.

> I forgot to mention that for this to work in 32k-timer mode, the my
> 32k-timer fixups for OMAP3430[1] are needed.

I'm pushing those today except the one I think breaks 15xx.

Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-11-23 20:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-20 22:16 [PATCH] ARM: OMAP: Enable OMAP3 SDRC clock on init Kevin Hilman
2007-11-20 22:44 ` Kevin Hilman
2007-11-20 22:58   ` Kevin Hilman
2007-11-23 20:34     ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox