From: Tony Lindgren <tony@atomide.com>
To: Chandra shekhar <x0044955@ti.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] OMAP: Moving TWL id for i2c in board files
Date: Fri, 23 Nov 2007 13:20:18 -0800 [thread overview]
Message-ID: <20071123212018.GI559@atomide.com> (raw)
In-Reply-To: <200711211506.lALF6e2t025107@dbdp31.itg.ti.com>
* Chandra shekhar <x0044955@ti.com> [071121 07:07]:
> This patch moves the the adapter number from twl core file to board files.
>
> Signed-off-by: chandra shekhar <x0044955@ti.com>
> ---
> drivers/i2c/chips/twl4030_core.c | 2 --
> include/asm/arch/board-2430sdp.h | 3 +++
> include/asm/arch/board-3430sdp.h | 2 ++
> 3 files changed, 5 insertions(+), 2 deletions(-)
>
> Index: linux-git-anand-19NOV/drivers/i2c/chips/twl4030_core.c
> ===================================================================
> --- linux-git-anand-19NOV.orig/drivers/i2c/chips/twl4030_core.c 2007-11-18 23:30:05.000000000 -0500
> +++ linux-git-anand-19NOV/drivers/i2c/chips/twl4030_core.c 2007-11-21 11:49:56.219607432 -0500
> @@ -131,8 +131,6 @@
> #define HFCLK_FREQ_38p4_MHZ (3 << 0)
> #define HIGH_PERF_SQ (1 << 3)
>
> -/* on I2C-1 for 2430SDP */
> -#define CONFIG_I2C_TWL4030_ID 1
>
> /**** Helper functions */
> static int
> Index: linux-git-anand-19NOV/include/asm/arch/board-2430sdp.h
> ===================================================================
> --- linux-git-anand-19NOV.orig/include/asm/arch/board-2430sdp.h 2007-11-18 23:31:52.000000000 -0500
> +++ linux-git-anand-19NOV/include/asm/arch/board-2430sdp.h 2007-11-21 11:49:25.828227624 -0500
> @@ -34,6 +34,9 @@
> #define OMAP24XX_ETHR_GPIO_IRQ 149
> #define SDP2430_CS0_BASE 0x04000000
>
> +/* on I2C-2 for 2430SDP */
> +#define CONFIG_I2C_TWL4030_ID 2
> +
> #define TWL4030_IRQNUM INT_24XX_SYS_NIRQ
>
> /* TWL4030 Primary Interrupt Handler (PIH) interrupts */
> Index: linux-git-anand-19NOV/include/asm/arch/board-3430sdp.h
> ===================================================================
> --- linux-git-anand-19NOV.orig/include/asm/arch/board-3430sdp.h 2007-11-18 23:31:52.000000000 -0500
> +++ linux-git-anand-19NOV/include/asm/arch/board-3430sdp.h 2007-11-21 11:49:41.887786200 -0500
> @@ -61,6 +61,8 @@
> #define ONENAND_MAP 0x20000000 /* OneNand flash */
>
> #ifdef CONFIG_TWL4030_CORE
> +/* on I2C-1 for 3430SDP */
> +#define CONFIG_I2C_TWL4030_ID 1
>
> #define TWL4030_IRQNUM INT_34XX_SYS_NIRQ
This will again break any chance of compiling in support for multiple
omap2 and omap3 boards. Could you please update this to get the ID
configuration from board-*.c files? See how tps65010 handles it
for example.
Regards,
Tony
prev parent reply other threads:[~2007-11-23 21:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 21:58 [PATCH] OMAP: Add OMAP_GPIO_SWITCH dependency for TUSB6010 on N800 Anderson Briglia
2007-10-22 0:06 ` Tony Lindgren
2007-10-22 16:07 ` Anderson Briglia
2007-11-21 15:06 ` [PATCH] OMAP: Moving TWL id for i2c in board files Chandra shekhar
2007-11-23 21:20 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071123212018.GI559@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=x0044955@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox