public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Gadiyar, Anand" <gadiyar@ti.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH RESEND] OMAP: DMA: Cleanup of DMA Request Lines
Date: Fri, 23 Nov 2007 13:42:11 -0800	[thread overview]
Message-ID: <20071123214211.GM559@atomide.com> (raw)
In-Reply-To: <010C7BAE6783F34D9AC336EE5A01A08804DC1218@dbde01.ent.ti.com>

Hi,

* Gadiyar, Anand <gadiyar@ti.com> [071121 20:57]:
> From: Anand Gadiyar <gadiyar@ti.com>
> 
> Added support for TI OMAP3430 and cleanup of DMA request lines.
> 
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> ---
>  include/asm-arm/arch-omap/dma.h |  152 +++++++++++++++++++++++++++++++---------
>  1 files changed, 120 insertions(+), 32 deletions(-)
> 
> Index: linux-git-19NOV/include/asm-arm/arch-omap/dma.h
> ===================================================================
> --- linux-git-19NOV.orig/include/asm-arm/arch-omap/dma.h	2007-11-18 23:31:52.000000000 -0500
> +++ linux-git-19NOV/include/asm-arm/arch-omap/dma.h	2007-11-22 01:13:23.109046296 -0500
> @@ -190,19 +190,40 @@
> +
> +#ifdef CONFIG_ARCH_OMAP2420
>  #define OMAP24XX_DMA_VLYNQ_TX		7	/* S_DMA_6 */
> +#else
> +#define OMAP24XX_DMA_EXT_DMAREQ2	7	/* S_DMA_6 */
> +#endif

As mentioned earlier, we don't want to have ifdef + else as it will
not work if we try to compile in support for 24xx and 34xx in the same
kernel.

Tony

      parent reply	other threads:[~2007-11-23 21:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-22  4:55 [PATCH RESEND] OMAP: DMA: Cleanup of DMA Request Lines Gadiyar, Anand
2007-11-22 11:57 ` Felipe Balbi
2007-11-22 13:56   ` Choraria, Rohit
2007-11-23 21:42 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071123214211.GM559@atomide.com \
    --to=tony@atomide.com \
    --cc=gadiyar@ti.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox